Skip to content

Commit d930b2e

Browse files
committed
bug #2052 [Map] Re-add keyword "symfony-ux", to fix Symfony Flex package.json resolving (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [Map] Re-add keyword "symfony-ux", to fix Symfony Flex `package.json` resolving | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> In #1937 I was asked to remove the keyword `symfony-ux` in favor `symfony` and `ux`, but it looks like it break Symfony Flex behaviour to resolve the package's `package.json`: https://github.com/symfony/flex/blob/2.x/src/PackageJsonSynchronizer.php#L372 No `importmap.php` nor `assets/controllers.json` were updated when installing UX Map bridges :( I'm adding back this keyword and removing the other ones. Sorry for the inconvenience 🙏 Commits ------- e417b4b [Map] Re-add keyword "symfony-ux", to fix Symfony Flex behaviour (importmap, controllers...)
2 parents 9e6920d + e417b4b commit d930b2e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/Map/src/Bridge/Google/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "symfony/ux-google-map",
33
"type": "symfony-ux-map-bridge",
44
"description": "Symfony UX Map GoogleMaps Bridge",
5-
"keywords": ["google-maps", "map", "symfony", "ux"],
5+
"keywords": ["symfony-ux", "google-maps", "map"],
66
"homepage": "https://symfony.com",
77
"license": "MIT",
88
"authors": [

src/Map/src/Bridge/Leaflet/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "symfony/ux-leaflet-map",
33
"type": "symfony-ux-map-bridge",
44
"description": "Symfony UX Map Leaflet Bridge",
5-
"keywords": ["leaflet", "map", "symfony", "ux"],
5+
"keywords": ["symfony-ux", "leaflet", "map"],
66
"homepage": "https://symfony.com",
77
"license": "MIT",
88
"authors": [

0 commit comments

Comments
 (0)