Skip to content

Commit cebd8e2

Browse files
committed
Upgrade Vitest, use a real browser for Map Bridges tests
1 parent 907eb05 commit cebd8e2

File tree

7 files changed

+856
-396
lines changed

7 files changed

+856
-396
lines changed

.github/workflows/test.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,4 +141,5 @@ jobs:
141141
restore-keys: |
142142
${{ runner.os }}-yarn-
143143
- run: yarn --immutable
144+
- run: yarn playwright install
144145
- run: yarn test

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,12 @@
1919
"@rollup/plugin-node-resolve": "^15.2.3",
2020
"@rollup/plugin-typescript": "^11.1.6",
2121
"@symfony/stimulus-testing": "^2.0.1",
22+
"@vitest/browser": "^2.0.5",
2223
"clean-css-cli": "^5.6.2",
24+
"playwright": "^1.47.0",
2325
"rollup": "^4.21.0",
2426
"tslib": "^2.6.3",
2527
"typescript": "^5.5.4",
26-
"vitest": "^0.34.6"
28+
"vitest": "^2.0.5"
2729
}
2830
}

src/Map/src/Bridge/Google/assets/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"devDependencies": {
3434
"@googlemaps/js-api-loader": "^1.16.6",
3535
"@hotwired/stimulus": "^3.0.0",
36-
"@types/google.maps": "^3.55.9",
37-
"happy-dom": "^14.12.3"
36+
"@types/google.maps": "^3.55.9"
3837
}
3938
}

src/Map/src/Bridge/Google/assets/vitest.config.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,21 @@ export default mergeConfig(
99
'@symfony/ux-map/abstract-map-controller': __dirname + '/../../../../assets/src/abstract_map_controller.ts',
1010
},
1111
},
12+
define: {
13+
// Prevent the following error:
14+
// ReferenceError: global is not defined
15+
// ❯ ../../../../../../node_modules/pretty-format/build/plugins/AsymmetricMatcher.js ../../../../../../../../../../node_modules/.vite/deps/@testing-library_dom.js:139:19
16+
// ❯ ../../../../../../node_modules/pretty-format/build/index.js ../../../../../../../../../../node_modules/.vite/deps/@testing-library_dom.js:805:7
17+
// ❯ ../../../../../../../../../../node_modules/.vite/deps/@testing-library_dom.js:13445:36
18+
global: {}
19+
},
1220
test: {
13-
// We need a browser(-like) environment to run the tests
14-
environment: 'happy-dom',
21+
browser: {
22+
enabled: true,
23+
provider: 'playwright', // or 'webdriverio'
24+
name: 'chromium', // browser name is required
25+
headless: true,
26+
},
1527
},
1628
})
1729
);

src/Map/src/Bridge/Leaflet/assets/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"devDependencies": {
3434
"@hotwired/stimulus": "^3.0.0",
3535
"@types/leaflet": "^1.9.12",
36-
"happy-dom": "^14.12.3",
3736
"leaflet": "^1.9.4"
3837
}
3938
}

src/Map/src/Bridge/Leaflet/assets/vitest.config.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,21 @@ export default mergeConfig(
1010
'leaflet/dist/leaflet.min.css': 'leaflet/dist/leaflet.css',
1111
},
1212
},
13+
define: {
14+
// Prevent the following error:
15+
// ReferenceError: global is not defined
16+
// ❯ ../../../../../../node_modules/pretty-format/build/plugins/AsymmetricMatcher.js ../../../../../../../../../../node_modules/.vite/deps/@testing-library_dom.js:139:19
17+
// ❯ ../../../../../../node_modules/pretty-format/build/index.js ../../../../../../../../../../node_modules/.vite/deps/@testing-library_dom.js:805:7
18+
// ❯ ../../../../../../../../../../node_modules/.vite/deps/@testing-library_dom.js:13445:36
19+
global: {}
20+
},
1321
test: {
14-
// We need a browser(-like) environment to run the tests
15-
environment: 'happy-dom',
22+
browser: {
23+
enabled: true,
24+
provider: 'playwright', // or 'webdriverio'
25+
name: 'chromium', // browser name is required
26+
headless: true,
27+
},
1628
},
1729
})
1830
);

0 commit comments

Comments
 (0)