Skip to content

Commit c68ee12

Browse files
committed
minor #2807 [Toolkit] Remove Kit::$uxIcon, make icons internal to the website (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [Toolkit] Remove `Kit::$uxIcon`, make icons internal to the website | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 43d7ca1 [Toolkit] Remove `Kit::$uxIcon`, make icons internal to the website
2 parents aa81715 + 43d7ca1 commit c68ee12

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

src/Toolkit/kits/shadcn/manifest.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@
22
"name": "Shadcn UI",
33
"description": "Component based on the Shadcn UI library, one of the most popular design systems in JavaScript world.",
44
"license": "MIT",
5-
"homepage": "https://ux.symfony.com/components",
6-
"ux-icon": "simple-icons:shadcnui"
5+
"homepage": "https://ux.symfony.com/components"
76
}

src/Toolkit/src/Kit/KitFactory.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public function createKitFromAbsolutePath(string $absolutePath): Kit
5353
homepage: $manifest['homepage'] ?? throw new \InvalidArgumentException('Manifest file is missing "homepage" key.'),
5454
license: $manifest['license'] ?? throw new \InvalidArgumentException('Manifest file is missing "license" key.'),
5555
description: $manifest['description'] ?? null,
56-
uxIcon: $manifest['ux-icon'] ?? null,
5756
);
5857

5958
$this->kitSynchronizer->synchronize($kit);
Loading

ux.symfony.com/templates/ux_packages/toolkit.html.twig

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,9 @@ tree templates/components
6464
<div class="mt-5 shadow-blur shadow-blur--rainbow shadow-blur--opacity-20" style="display: grid; gap: 2rem; grid-template-columns: repeat(auto-fill, minmax(min(100%, 420px), 1fr));">
6565
{% for kit_id, kit in kits %}
6666
<div class="PackageBox">
67-
{% if kit.uxIcon %}
68-
<div class="PackageBox_logo">
69-
<twig:ux:icon name="{{ kit.uxIcon }}" alt="{{ kit.name }}" style="color: #fff; width: 50%; height: 50%;" />
70-
</div>
71-
{% endif %}
67+
<div class="PackageBox_logo">
68+
<twig:ux:icon name="toolkit:{{ kit_id }}" alt="{{ kit.name }}" style="color: #fff; width: 50%; height: 50%;" />
69+
</div>
7270
<div class="PackageBox_content">
7371
<h2 class="PackageBox_title">
7472
<a href="{{ path('app_toolkit_kit', {kitId: kit_id}) }}" class="PackageBox_link">{{ kit.name }}</a>

0 commit comments

Comments
 (0)