Skip to content

Commit ae2cf69

Browse files
committed
Revert typing fix for hooks (done in another pr)
1 parent 93c65b3 commit ae2cf69

File tree

4 files changed

+11
-23
lines changed

4 files changed

+11
-23
lines changed

src/LiveComponent/assets/dist/Component/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ export type ComponentHooks = {
1313
'response:error': (backendResponse: BackendResponse, controls: {
1414
displayError: boolean;
1515
}) => MaybePromise;
16-
'loading.state:started': (element: HTMLElement, request: BackendRequest) => MaybePromise;
17-
'loading.state:finished': (element: HTMLElement) => MaybePromise;
16+
'loading.state.started': (element: HTMLElement, request: BackendRequest) => MaybePromise;
17+
'loading.state.finished': (element: HTMLElement) => MaybePromise;
1818
'model:set': (model: string, value: any, component: Component) => MaybePromise;
1919
};
2020
export type ComponentHookName = keyof ComponentHooks;
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import type { ComponentHookName, ComponentHookCallback } from './Component';
21
export default class {
32
private hooks;
4-
register<T extends string | ComponentHookName = ComponentHookName>(hookName: T, callback: ComponentHookCallback<T>): void;
5-
unregister<T extends string | ComponentHookName = ComponentHookName>(hookName: T, callback: ComponentHookCallback<T>): void;
6-
triggerHook<T extends string | ComponentHookName = ComponentHookName>(hookName: T, ...args: Parameters<ComponentHookCallback<T>>): void;
3+
register(hookName: string, callback: (...args: any[]) => void): void;
4+
unregister(hookName: string, callback: (...args: any[]) => void): void;
5+
triggerHook(hookName: string, ...args: any[]): void;
76
}

src/LiveComponent/assets/src/Component/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ export type ComponentHooks = {
2222
'request:started': (requestConfig: any) => MaybePromise,
2323
'render:finished': (component: Component) => MaybePromise,
2424
'response:error': (backendResponse: BackendResponse, controls: { displayError: boolean }) => MaybePromise,
25-
'loading.state:started': (element: HTMLElement, request: BackendRequest) => MaybePromise,
26-
'loading.state:finished': (element: HTMLElement) => MaybePromise,
25+
'loading.state.started': (element: HTMLElement, request: BackendRequest) => MaybePromise,
26+
'loading.state.finished': (element: HTMLElement) => MaybePromise,
2727
'model:set': (model: string, value: any, component: Component) => MaybePromise,
2828
};
2929

src/LiveComponent/assets/src/HookManager.ts

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,13 @@
1-
import type { ComponentHookName, ComponentHookCallback } from './Component';
2-
31
export default class {
4-
private hooks: Map<ComponentHookName | string, Array<(...args: any[]) => void>> = new Map();
2+
private hooks: Map<string, Array<(...args: any[]) => void>> = new Map();
53

6-
register<T extends string | ComponentHookName = ComponentHookName>(
7-
hookName: T,
8-
callback: ComponentHookCallback<T>
9-
): void {
4+
register(hookName: string, callback: (...args: any[]) => void): void {
105
const hooks = this.hooks.get(hookName) || [];
116
hooks.push(callback);
127
this.hooks.set(hookName, hooks);
138
}
149

15-
unregister<T extends string | ComponentHookName = ComponentHookName>(
16-
hookName: T,
17-
callback: ComponentHookCallback<T>
18-
): void {
10+
unregister(hookName: string, callback: (...args: any[]) => void): void {
1911
const hooks = this.hooks.get(hookName) || [];
2012
const index = hooks.indexOf(callback);
2113
if (index === -1) {
@@ -26,10 +18,7 @@ export default class {
2618
this.hooks.set(hookName, hooks);
2719
}
2820

29-
triggerHook<T extends string | ComponentHookName = ComponentHookName>(
30-
hookName: T,
31-
...args: Parameters<ComponentHookCallback<T>>
32-
): void {
21+
triggerHook(hookName: string, ...args: any[]): void {
3322
const hooks = this.hooks.get(hookName) || [];
3423
hooks.forEach((callback) => callback(...args));
3524
}

0 commit comments

Comments
 (0)