Skip to content

Commit a76534b

Browse files
committed
minor #617 imp: install PHP-CS-Fixer locally, allowing us to run in locally (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- imp: install PHP-CS-Fixer locally, allowing us to run in locally | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT After opening #616, the CI showed me a lot of style issues in the PHP code: <img width="537" alt="image" src="https://user-images.githubusercontent.com/2103975/208297036-3521128f-c2cc-4847-92c3-30a8d1b2a4ce.png"> I don't have PHP CS Fixer globally installed on my machine because that's a bad practice, and I don't want to fix those errors manually (the time is precious). So, this PR adds PHP CS Fixer locally. Commits ------- 514a7ce imp: install PHP-CS-Fixer locally, allowing us to run in locally
2 parents 6171b06 + 514a7ce commit a76534b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ jobs:
1010
- uses: shivammathur/setup-php@v2
1111
with:
1212
php-version: '8.0'
13-
tools: php-cs-fixer
13+
- uses: ramsey/composer-install@v2
1414
- name: php-cs-fixer
15-
run: php-cs-fixer fix --dry-run --diff
15+
run: ./vendor/bin/php-cs-fixer fix --dry-run --diff
1616

1717
coding-style-js:
1818
runs-on: ubuntu-latest

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"name": "symfony/ux",
33
"license": "MIT",
44
"require-dev": {
5-
"symfony/filesystem": "^5.2|^6.0"
5+
"symfony/filesystem": "^5.2|^6.0",
6+
"php-cs-fixer/shim": "^3.13"
67
}
78
}

0 commit comments

Comments
 (0)