Skip to content

Commit 64637df

Browse files
Apply suggestions from code review
Co-authored-by: Simon André <smn.andre@gmail.com>
1 parent 4b79580 commit 64637df

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Translator/doc/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Don't worry about your final bundle size, only the translations you use will be
7878
Configuring the dumped translations
7979
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
8080

81-
By default, all your translations will be dumped as JavaScript. You can restrict the dumped translations by either
81+
By default, all your translations will be exported. You can restrict the dumped messages by either
8282
including or excluding translation domains in your ``config/packages/ux_translator.yaml`` file:
8383

8484
.. code-block:: yaml

src/Translator/src/DependencyInjection/Configuration.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ public function getConfigTreeBuilder(): TreeBuilder
2929
->children()
3030
->scalarNode('dump_directory')->defaultValue('%kernel.project_dir%/var/translations')->end()
3131
->arrayNode('excluded_domains')
32-
->info('List of domains to exclude from the generated translations')
32+
->info('List of domains to exclude from the generated translations.')
3333
->scalarPrototype()->end()
3434
->defaultValue([])
3535
->end()
3636
->arrayNode('included_domains')
37-
->info('List of domains to include in the generated translations')
37+
->info('List of domains to include in the generated translations. By default, all domains are included.')
3838
->scalarPrototype()->end()
3939
->defaultValue([])
4040
->end()

src/Translator/src/DependencyInjection/UxTranslatorExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ public function load(array $configs, ContainerBuilder $container)
3838
$dumperDefinition = $container->getDefinition('ux.translator.translations_dumper');
3939
$dumperDefinition->setArgument(0, $config['dump_directory']);
4040

41-
if (0 !== \count($config['excluded_domains'])) {
41+
if ($config['excluded_domains']) {
4242
$dumperDefinition->addMethodCall('setExcludedDomains', [$config['excluded_domains']]);
4343
}
44-
if (0 !== \count($config['included_domains'])) {
44+
if ($config['included_domains']) {
4545
$dumperDefinition->addMethodCall('setIncludedDomains', [$config['included_domains']]);
4646
}
4747
}

0 commit comments

Comments
 (0)