Skip to content

Commit 6165384

Browse files
smnandreweaverryan
authored andcommitted
[Twig][Live] Skip Twig 3.9 🚒 (do not set use_yield = true for now)
1 parent ca890f0 commit 6165384

File tree

6 files changed

+7
-15
lines changed

6 files changed

+7
-15
lines changed

src/LiveComponent/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"php": ">=8.1",
3030
"symfony/property-access": "^5.4.5|^6.0|^7.0",
3131
"symfony/ux-twig-component": "^2.8",
32-
"twig/twig": "^2.14.7|^3.0.4"
32+
"twig/twig": "^2.14.7|~3.8.0"
3333
},
3434
"require-dev": {
3535
"doctrine/annotations": "^1.0",

src/StimulusBundle/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"symfony/dependency-injection": "^5.4|^6.0|^7.0",
1919
"symfony/finder": "^5.4|^6.0|^7.0",
2020
"symfony/http-kernel": "^5.4|^6.0|^7.0",
21-
"twig/twig": "^2.15.3|^3.4.3",
21+
"twig/twig": "^2.15.3|~3.8.0",
2222
"symfony/deprecation-contracts": "^2.0|^3.0"
2323
},
2424
"require-dev": {

src/StimulusBundle/src/Helper/StimulusHelper.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ final class StimulusHelper
2727
public function __construct(?Environment $twig)
2828
{
2929
// Twig needed just for its escaping mechanism
30-
$this->twig = $twig ?? new Environment(new ArrayLoader(), [
31-
'use_yield' => true,
32-
]);
30+
$this->twig = $twig ?? new Environment(new ArrayLoader());
3331
}
3432

3533
public function createStimulusAttributes(): StimulusAttributes

src/StimulusBundle/tests/Dto/StimulusAttributesTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ final class StimulusAttributesTest extends TestCase
2424

2525
protected function setUp(): void
2626
{
27-
$this->stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader(), [
28-
'use_yield' => true,
29-
]));
27+
$this->stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader()));
3028
}
3129

3230
public function testAddAction(): void

src/TwigComponent/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"symfony/deprecation-contracts": "^2.2|^3.0",
3232
"symfony/event-dispatcher": "^5.4|^6.0|^7.0",
3333
"symfony/property-access": "^5.4|^6.0|^7.0",
34-
"twig/twig": "^2.14.7|^3.0.4"
34+
"twig/twig": "^2.14.7|~3.8.0"
3535
},
3636
"require-dev": {
3737
"symfony/console": "^5.4|^6.0|^7.0",

src/TwigComponent/tests/Unit/ComponentAttributesTest.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,7 @@ public function testCanAddStimulusControllerViaStimulusAttributes(): void
133133
'data-live-data-value' => '{}',
134134
]);
135135

136-
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader(), [
137-
'use_yield' => true,
138-
]));
136+
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader()));
139137
$stimulusAttributes->addController('foo', ['name' => 'ryan', 'some_array' => ['a', 'b']]);
140138
$attributes = $attributes->defaults($stimulusAttributes);
141139

@@ -160,9 +158,7 @@ public function testCanAddStimulusActionViaStimulusAttributes(): void
160158
'data-action' => 'live#foo',
161159
]);
162160

163-
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader(), [
164-
'use_yield' => true,
165-
]));
161+
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader()));
166162
$stimulusAttributes->addAction('foo', 'barMethod');
167163
$attributes = $attributes->defaults([...$stimulusAttributes]);
168164

0 commit comments

Comments
 (0)