Move query string initializer to PostMount

Author: squrious

src/LiveComponent/src/DependencyInjection/LiveComponentExtension.php

@@ -229,6 +229,7 @@ function (ChildDefinition $definition, AsLiveComponent $attribute) {
                 new Reference('request_stack'),
                 new Reference('ux.live_component.metadata_factory'),
                 new Reference('ux.live_component.query_string_props_extractor'),
+                new Reference('property_accessor'),
             ])
             ->addTag('kernel.event_subscriber');
 

src/LiveComponent/src/EventListener/QueryStringInitializeSubscriber.php

@@ -13,9 +13,11 @@
 
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\HttpFoundation\RequestStack;
+use Symfony\Component\PropertyAccess\Exception\ExceptionInterface as PropertyAccessExceptionInterface;
+use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
 use Symfony\UX\LiveComponent\Metadata\LiveComponentMetadataFactory;
 use Symfony\UX\LiveComponent\Util\QueryStringPropsExtractor;
-use Symfony\UX\TwigComponent\Event\PreMountEvent;
+use Symfony\UX\TwigComponent\Event\PostMountEvent;
 
 /**
  * @author Nicolas Rigaud <squrious@protonmail.com>
@@ -30,17 +32,18 @@ public function __construct(
         private readonly RequestStack $requestStack,
         private readonly LiveComponentMetadataFactory $metadataFactory,
         private readonly QueryStringPropsExtractor $queryStringPropsExtractor,
+        private readonly PropertyAccessorInterface $propertyAccessor,
     ) {
     }
 
     public static function getSubscribedEvents(): array
     {
         return [
-            PreMountEvent::class => 'onPreMount',
+            PostMountEvent::class => ['onPostMount', 256],
         ];
     }
 
-    public function onPreMount(PreMountEvent $event): void
+    public function onPostMount(PostMountEvent $event): void
     {
         if (!$event->getMetadata()->get('live', false)) {
             // Not a live component
@@ -61,6 +64,14 @@ public function onPreMount(PreMountEvent $event): void
 
         $queryStringData = $this->queryStringPropsExtractor->extract($request, $metadata, $event->getComponent());
 
-        $event->setData(array_merge($event->getData(), $queryStringData));
+        $component = $event->getComponent();
+
+        foreach ($queryStringData as $name => $value) {
+            try {
+                $this->propertyAccessor->setValue($component, $name, $value);
+            } catch (PropertyAccessExceptionInterface $exception) {
+                // Ignore errors
+            }
+        }
     }
 }

src/LiveComponent/tests/Fixtures/Component/ComponentWithUrlBoundProps.php

@@ -47,6 +47,6 @@ class ComponentWithUrlBoundProps
 
     public function modifyProp7(LiveProp $prop): LiveProp
     {
-        return $prop->withUrl(true);
+        return $prop->withUrl($this->prop7InUrl);
     }
 }

src/LiveComponent/tests/Fixtures/templates/render_component_with_url_bound_props.html.twig

@@ -1 +1,3 @@
-{{ component('component_with_url_bound_props') }}
+{{ component('component_with_url_bound_props', {
+    prop7InUrl: true
+}) }}

src/LiveComponent/tests/Functional/EventListener/QueryStringInitializerSubscriberTest.php

@@ -21,6 +21,7 @@ class QueryStringInitializerSubscriberTest extends KernelTestCase
     public function testQueryStringPropsInitialization()
     {
         $this->browser()
+            ->throwExceptions()
             ->get('/render-template/render_component_with_url_bound_props?prop1=foo&prop2=42&prop3[]=foo&prop3[]=bar&prop4=unbound&prop5[address]=foo&prop5[city]=bar&field6=foo&prop7=foo')
             ->assertSuccessful()
             ->assertContains('Prop1: foo')

src/TwigComponent/tests/Integration/ComponentExtensionTest.php

@@ -14,7 +14,6 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\UX\TwigComponent\Tests\Fixtures\User;
 use Twig\Environment;
-use Twig\Error\RuntimeError;
 
 /**
  * @author Kevin Bond <kevinbond@gmail.com>