Fiw after review

Author: Fan2Shrek

src/Turbo/src/DependencyInjection/Compiler/RegisterMercureHubs.php renamed to src/Turbo/src/DependencyInjection/Compiler/RegisterMercureHubsPass.php

@@ -23,11 +23,11 @@
  *
  * @author Pierre Ambroise<pierre27.ambroise@gmail.com>
  */
-final class RegisterMercureHubs implements CompilerPassInterface
+final class RegisterMercureHubsPass implements CompilerPassInterface
 {
     public function process(ContainerBuilder $container)
     {
-        foreach ($container->findTaggedServiceIds('mercure.hub') as $hubId => $tag) {
+        foreach ($container->findTaggedServiceIds('mercure.hub') as $hubId => $tags) {
             $name = str_replace('mercure.hub.', '', $hubId);
 
             $container->register("turbo.mercure.$name.renderer", TurboStreamListenRenderer::class)
@@ -37,9 +37,11 @@ public function process(ContainerBuilder $container)
                 ->addArgument(new Reference('twig'))
                 ->addTag('turbo.renderer.stream_listen', ['transport' => $name]);
 
-            if (isset($tag['default']) && $tag['default']) {
-                $container->getDefinition("turbo.mercure.{$name}.renderer")
-                    ->addTag('turbo.renderer.stream_listen', ['transport' => 'default']);
+            foreach ($tags as $tag) {
+                if (isset($tag['default']) && $tag['default'] && 'default' !== $name) {
+                    $container->getDefinition("turbo.mercure.$name.renderer")
+                        ->addTag('turbo.renderer.stream_listen', ['transport' => 'default']);
+                }
             }
 
             $container->register("turbo.mercure.$name.broadcaster", Broadcaster::class)

src/Turbo/src/TurboBundle.php

@@ -15,7 +15,7 @@
 use Symfony\Component\DependencyInjection\Compiler\PassConfig;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
-use Symfony\UX\Turbo\DependencyInjection\Compiler\RegisterMercureHubs;
+use Symfony\UX\Turbo\DependencyInjection\Compiler\RegisterMercureHubsPass;
 
 /**
  * @author Kévin Dunglas <kevin@dunglas.fr>
@@ -29,7 +29,7 @@ public function build(ContainerBuilder $container): void
     {
         parent::build($container);
 
-        $container->addCompilerPass(new RegisterMercureHubs());
+        $container->addCompilerPass(new RegisterMercureHubsPass());
 
         $container->addCompilerPass(new class implements CompilerPassInterface {
             public function process(ContainerBuilder $container): void

src/Turbo/tests/Compiler/RegisterMercureHubsPassTest.php

@@ -0,0 +1,51 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace src\Turbo\tests\Compiler;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\UX\Turbo\DependencyInjection\Compiler\RegisterMercureHubsPass;
+
+final class RegisterMercureHubsPassTest extends TestCase
+{
+    public function testProcess(): void
+    {
+        $pass = new RegisterMercureHubsPass();
+
+        $container = new ContainerBuilder();
+        $container->register('hub')
+            ->addTag('mercure.hub');
+
+        $pass->process($container);
+
+        $this->assertTrue($container->has('turbo.mercure.hub.renderer'));
+        $this->assertTrue($container->has('turbo.mercure.hub.broadcaster'));
+    }
+
+    public function testProcessWithDefault(): void
+    {
+        $pass = new RegisterMercureHubsPass();
+
+        $container = new ContainerBuilder();
+        $container->register('hub1')
+            ->addTag('mercure.hub');
+
+        $container->register('default_hub')
+            ->addTag('mercure.hub', ['default' => true]);
+
+        $pass->process($container);
+
+        $this->assertSame([
+            'transport' => 'default',
+        ], $container->getDefinition('turbo.mercure.default_hub.renderer')->getTag('turbo.renderer.stream_listen')[1]);
+    }
+}