hotfix: missing the call to InstanceOfSupportStrategy #9233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Feb 9, 2018
There was a problem hiding this comment.
This is correct because the signature of the function is:
public function addWorkflow(WorkflowInterface $workflow, WorkflowSupportStrategyInterface $supportStrategy)
{
$this->workflows[] = array($workflow, $supportStrategy);
}Thanks @Simperfit!
|
By the way, I don't know anything about the Workflow component, but |
javiereguiluz
added a commit
that referenced
this pull request
Feb 9, 2018
…mperfit, javiereguiluz) This PR was merged into the master branch. Discussion ---------- hotfix: missing the call to InstanceOfSupportStrategy Updating the exemple I missed the call to instanceOfSupportStrategy which is now needed. Commits ------- fbcf572 Added the use import 379a939 hotfix: missing the call to InstanceOfSupportStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the exemple I missed the call to instanceOfSupportStrategy which is now needed.