Skip to content

Conversation

@javiereguiluz
Copy link
Member

This fixes #8999.

@javiereguiluz
Copy link
Member Author

In this comment Ryan said that we can use ParameterBagInterface as the type-hint instead of ContainerBagInterface. Are we sure about that? Thanks!

:class:`Symfony\\Component\\DependencyInjection\\ParameterBag\\ParameterBag`
objects used in other parts of the framework::

// src/Service/MessageGenerator.php

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of the services.yml/xml would be nice also. How do I configure which services are inside the ContainerBag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the ContainerBag there are no services, just all container parameters. About the YAML/XML config ... since we're promoting autowiring and type-hint injection, I prefer to keep consistent with the rest of the docs.

Copy link

@jordisala1991 jordisala1991 Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but how do I say that inside this containerBag there is a param called 'parameter_name' (your example)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordisala1991 I had the same question as you, read the docs again and now my understanding is that you get each and every available parameters in that bag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reworded everything. Hopefully it's easier to understand now. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I get it! Thank you @javiereguiluz


use Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface;

class MessageGenerator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more concrete example with a Mailer class using a mailer_sender parameter in a sendWelcomeEmail() method maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of giving a name to the parameter. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New support for getting parameters via injection

8 participants