Updated the configuration/* files #8732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
more_config_updates
branch
from
068a206 to
0684c4a
Compare
weaverryan
added a commit
that referenced
this pull request
Nov 24, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8732). Discussion ---------- Updated the configuration/* files This fixes #8725 and required a ton of changes. Besides, I don't really like the config/* articles at all. I'll try to improve things after Symfony 4 release. Thanks! Commits ------- 6aabd10 Removed links to specific files (they are not easy to maintain) 0684c4a Updated the configuration/* files
weaverryan
added a commit
that referenced
this pull request
Nov 24, 2017
|
Huge work. Thank you Javier! I made some tweaks in sha: d450dab But yea, I don't really like many of these articles. I think they can be simplified dramatically and slimmed down. I will let you do that after 4.0. |
xabbuh
added a commit
that referenced
this pull request
Nov 24, 2017
* 4.0: (28 commits) typo Clarifying that our code is just additions [#8732] Minor tweaks minor tweaks updating link to be version independent Adding yarn install text Reduce ambiguity of encore installation Remove svn & changelog articles Add instructions to install dependencies before using them Fixed some typos Fix upgrading to Flex Removed links to specific files (they are not easy to maintain) Correction in the console command folder Fixed some typos Updated the configuration/* files Add example usage of the link script Change service override docs removing need for annotation route import change linking directly and marking articles as orphans adding other dirs ...
weaverryan
added a commit
that referenced
this pull request
Nov 24, 2017
* origin/master: (38 commits) typo Clarifying that our code is just additions [#8732] Minor tweaks minor tweaks updating link to be version independent Adding yarn install text Reduce ambiguity of encore installation Remove svn & changelog articles Add instructions to install dependencies before using them Fixed some typos Fix upgrading to Flex Removed links to specific files (they are not easy to maintain) Correction in the console command folder Fixed some typos Updated the configuration/* files Add example usage of the link script Change service override docs removing need for annotation route import change linking directly and marking articles as orphans adding other dirs ...
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8725 and required a ton of changes. Besides, I don't really like the config/* articles at all. I'll try to improve things after Symfony 4 release. Thanks!