Skip to content

Updated http_cache/* articles to Symfony 4 #8682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2017

Conversation

javiereguiluz
Copy link
Member

I have a question about the old AppCache class. I've moved to src/AppCache.php under App namespace. Is that correct? And also: should we rename it to Cache or KernelCache or something else? AppCache was great when we had AppKernel ... but now we have just Kernel.

@weaverryan
Copy link
Member

Hmmmm.

Two things:

  1. One big difference is that, in Flex, you will need to create the "cache" kernel file, because you do not have it by default (like in the SE). @javiereguiluz have you made changes to the docs to reflect this? I admittedly only did a quick scan, but I didn't see it. It's out-of-scope, but perhaps we need a make: command to create this for you (and at least suggest the changes you also need in index.php).

  2. What to call this class? I think CacheKernel - it's your kernel, but a Cache version if it :).

@weaverryan
Copy link
Member

Status: Needs work

@weaverryan
Copy link
Member

Thanks!

@weaverryan weaverryan merged commit 1e75772 into symfony:4.0 Nov 27, 2017
weaverryan added a commit that referenced this pull request Nov 27, 2017
…, weaverryan)

This PR was merged into the 4.0 branch.

Discussion
----------

Updated http_cache/* articles to Symfony 4

I have a question about the old `AppCache` class. I've moved to `src/AppCache.php` under `App` namespace. Is that correct? And also: should we rename it to `Cache` or `KernelCache` or something else? AppCache was great when we had AppKernel ... but now we have just Kernel.

Commits
-------

1e75772 Merge branch '4.0' into update_http_cache
664f280 Merge branch '4.0' into update_http_cache
d512875 Updated http_cache/* articles to Symfony 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants