Updated code example for LDAP integration #7917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LdapClient class mentioned in the code example has been deprecated. The update example, uses the Ldap class directly, as is recommended in the deprecation notice.
javiereguiluz
requested changes
May 21, 2017
|
Sorry about that! I have corrected it by adding a commit to this PR; let me know if you want me to squash my commits and submit a new PR. |
xabbuh
reviewed
May 26, 2017
security/ldap.rst
Outdated
| true, | ||
|
|
||
| )); | ||
| ->setDefinition('ext_ldap_adapter', new Definition(Ldap::class, array( |
There was a problem hiding this comment.
should be Adapter::class instead of Ldap::class here
xabbuh
approved these changes
May 26, 2017
|
Indeed... sorry about that. Should be good now (I hope)... |
|
Thank you @pmlt. |
xabbuh
added a commit
that referenced
this pull request
May 26, 2017
This PR was squashed before being merged into the 3.2 branch (closes #7917). Discussion ---------- Updated code example for LDAP integration The LdapClient class mentioned in the code example has been deprecated. The update example, uses the Ldap class directly, as is recommended in the deprecation notice. Commits ------- 91e3e7d Updated code example for LDAP integration
xabbuh
added a commit
that referenced
this pull request
May 26, 2017
xabbuh
added a commit
that referenced
this pull request
Jun 3, 2017
* 3.2: (22 commits) setfacl commands in the right order [#7941] use class constant Update guard_authentication.rst Fix typo Fixed code indentation use Ldap instead of the deprecated LdapClient Fix choice keys and values for custom field types [#7946] fix PHP parameter config example Tiny clarification to Finder component docs [#7917] add LDAP extension link Updated code example for LDAP integration Syntax to create an email Update usage.rst Correct default firewall name on Security docs Fix small typo Change some examples to remove references to gender types Remove remember me from interactive login examples added missing ClassMetadata incorrect placeholdes for leave/enter transitions Update caution about eraseCredentials ...
xabbuh
added a commit
that referenced
this pull request
Jun 3, 2017
* 3.4: (27 commits) setfacl commands in the right order add missing options allowed with an env variable [#7941] use class constant Update guard_authentication.rst Fix typo in a class name Fix typo Fixed trivial code example typo Fix typo Fix method reference (`getSubscribedServices()` instead of `getSubscribedEvents()`) Fixed code indentation use Ldap instead of the deprecated LdapClient Fix choice keys and values for custom field types [#7946] fix PHP parameter config example Tiny clarification to Finder component docs [#7917] add LDAP extension link Updated code example for LDAP integration Syntax to create an email Update usage.rst Correct default firewall name on Security docs Fix small typo ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LdapClient class mentioned in the code example has been deprecated.
The update example, uses the Ldap class directly, as is recommended in
the deprecation notice.