Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed formatting issues #6011

Closed

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

This is how these issues are displayed on symfony.com right now:

issue1


issue2


issue3


issue4


issue5

@@ -277,8 +277,7 @@ controller:
in the :class:`Symfony\\Component\\Routing\\Generator\\UrlGeneratorInterface`.

:method:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller::getDoctrine` (service: ``doctrine``)

*Simply inject doctrine instead of fetching it from the container*
Simply inject doctrine instead of fetching it from the container.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we really not have italic text in a definition list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can maintain the italic text. I removed it because it looked wrong to me. I've just restored it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue actually was the blank line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That generated an ugly blockquote instead of the usual paragraph text.

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 16, 2015

Thanks again Javier!

xabbuh added a commit that referenced this pull request Dec 16, 2015
This PR was squashed before being merged into the 2.3 branch (closes #6011).

Discussion
----------

Fixed formatting issues

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | -

This is how these issues are displayed on symfony.com right now:

![issue1](https://cloud.githubusercontent.com/assets/73419/11779238/2ff1cf62-a25a-11e5-81a6-d446a3d7f499.png)

---

![issue2](https://cloud.githubusercontent.com/assets/73419/11779241/31dcc912-a25a-11e5-80de-67741d7318da.png)

---

![issue3](https://cloud.githubusercontent.com/assets/73419/11779243/337e8eae-a25a-11e5-867b-d388b4f15f94.png)

---

![issue4](https://cloud.githubusercontent.com/assets/73419/11779248/358e0a26-a25a-11e5-9764-3b26892dd363.png)

---

![issue5](https://cloud.githubusercontent.com/assets/73419/11779250/375762e4-a25a-11e5-93b9-a00684fb0f7c.png)

Commits
-------

c7e78db Fixed formatting issues
@xabbuh xabbuh closed this Dec 16, 2015
@javiereguiluz javiereguiluz deleted the fix_formatting_issues branch May 24, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants