-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookbook grammar and style fixes #5427
Changes from 10 commits
bed8824
2ec4855
ba6f59f
21ebbd4
974e17f
a0abc5d
136230f
c56f912
2af84eb
a75cc15
797aab7
1cff826
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ How to Master and Create new Environments | |
|
||
Every application is the combination of code and a set of configuration that | ||
dictates how that code should function. The configuration may define the | ||
database being used, whether or not something should be cached, or how verbose | ||
database being used, if something should be cached or how verbose | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the comma should be removed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you sure that this comma is useless? The text is describing three separate things, so I find it normal that they are separated by the comma and the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, you're right. I misunderstood the sentence before (didn't read it carefully enough). Sorry for that. |
||
logging should be. In Symfony, the idea of "environments" is the idea that | ||
the same codebase can be run using multiple different configurations. For | ||
example, the ``dev`` environment should use configuration that makes development | ||
|
@@ -170,10 +170,10 @@ this code and changing the environment string. | |
|
||
Important, but unrelated to the topic of *environments* is the ``false`` | ||
argument as the second argument to the ``AppKernel`` constructor. This | ||
specifies whether or not the application should run in "debug mode". Regardless | ||
specifies if the application should run in "debug mode". Regardless | ||
of the environment, a Symfony application can be run with debug mode | ||
set to ``true`` or ``false``. This affects many things in the application, | ||
such as whether or not errors should be displayed or if cache files are | ||
such as if errors should be displayed or if cache files are | ||
dynamically rebuilt on each request. Though not a requirement, debug mode | ||
is generally set to ``true`` for the ``dev`` and ``test`` environments | ||
and ``false`` for the ``prod`` environment. | ||
|
@@ -322,7 +322,7 @@ The new environment is now accessible via:: | |
.. note:: | ||
|
||
Some environments, like the ``dev`` environment, are never meant to be | ||
accessed on any deployed server by the general public. This is because | ||
accessed on any deployed server by the public. This is because | ||
certain environments, for debugging purposes, may give too much information | ||
about the application or underlying infrastructure. To be sure these environments | ||
aren't accessible, the front controller is usually protected from external | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
behavior is correct (we use American English)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks.