Skip to content

[Cookbook][Session] some language tweaks #5081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2015
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 13, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

and you want to use this as the locale for the given user. To accomplish this,
you can hook into the login process and update the user's session with the
this locale value before they are redirected to their first page.
Assumed you have defined a ``locale`` property on your ``User`` entity and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose you have defined...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks perfect - so I made this last change at sha: 45aff1d

Thanks Christian!

@weaverryan weaverryan merged commit 5377525 into symfony:2.3 Mar 14, 2015
weaverryan added a commit that referenced this pull request Mar 14, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Session] some language tweaks

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

5377525 some language tweaks
weaverryan added a commit that referenced this pull request Mar 14, 2015
weaverryan added a commit that referenced this pull request Mar 14, 2015
* 2.3:
  [#5081] Very minor language tweak
  [#5008] Shortening section and moving much of the note to reference
  Added a note about how to enable http_method_override for caching kernels
  some language tweaks
  Reworded again the note about "optional options"
  Reworded the explanation about "optional options"
  Minow grammar fix
  Added a note about the Symfony versions affected by ICU problems
  Reworded the explanation about optional command options
@xabbuh xabbuh deleted the pr-4875 branch March 16, 2015 07:21
@xabbuh
Copy link
Member Author

xabbuh commented Mar 16, 2015

Thanks for the tweak, Ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants