Skip to content

Compiled PHP for customized route matching #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Compiled PHP for customized route matching #4343

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
707d9e1
Compiled PHP for customized route matching
GeertDD Oct 20, 2014
4a58d0b
It seems strpos() is used instead of rtrim()
GeertDD Oct 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/routing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ variables that are passed into the expression:
Behind the scenes, expressions are compiled down to raw PHP. Our example
would generate the following PHP in the cache directory::

if (rtrim($pathinfo, '/contact') === '' && (
if ('/contact' === $pathinfo && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be: if (0 === strpos($pathinfo, '/_profiler') (since this example is just copied verbatim from the generated cache file)

in_array($context->getMethod(), array(0 => "GET", 1 => "HEAD"))
&& preg_match("/firefox/i", $request->headers->get("User-Agent"))
)) {
Expand Down