[Testing] Update nullable types #19786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codebase as been recently updated to replace implicit nullable types with explicit ones, but i think the doc has not been updated. This PR is just an "example" on this page. How do you think we should handle this ? Create a "meta-issue" and split the work by component ?
OskarStark
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
IMHO no need to add a meta issue, but we could add a DOCtor-RST rule which spits implicit nullable typehints.
Do you want to give it a try @smnandre ?
|
I'm not sure to understand the CI/Code Blocks fails here 🤷♂️ Concerning the DOCtor-RST rule, if you can point me in some direction / show some examples i can try :) |
smnandre
added a commit
to smnandre/symfony-docs
that referenced
this pull request
Apr 13, 2024
Maybe it should be: - request(
+ public function request( |
Sure, the repo can be found here: I created a new issue with some more information |
OskarStark
added a commit
that referenced
this pull request
Apr 15, 2024
|
Thank you Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony codebase as been recently updated to replace implicit nullable types with explicit ones, but i think the code shown in documentation (method signatures or examples) has not been updated at the same time.
This PR is just a small "example" of what's to be updated on the Testing page
How do you think we should handle this ?
Create a "meta-issue" and split the work by component ?