Skip to content

Conversation

@N-Silbernagel
Copy link
Contributor

In the Documentation for the VarDumper component in the "The Dump server" section, the code for configuring the Dump Server outside of a symfony application has an error.

The "setHandler" callback has the return type "?string" but is missing a return statement. This results in the error "{closure}(): Return value must be of type ?string, none returned".

Fix error in code for setting VarDumpServer in non-symfony applications
@carsonbot carsonbot added this to the 6.4 milestone Feb 5, 2024
@OskarStark OskarStark changed the title Add return to non-symfony VarDumper::setHandler Add return to non-symfony VarDumper::setHandler() Feb 5, 2024
@OskarStark OskarStark changed the title Add return to non-symfony VarDumper::setHandler() Add return to VarDumper::setHandler() Feb 5, 2024
@carsonbot carsonbot changed the title Add return to VarDumper::setHandler() [VarDumper] Add return to VarDumper::setHandler() Feb 6, 2024
@javiereguiluz
Copy link
Member

Good catch Nils! Thanks and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 92cfb30 into symfony:6.4 Feb 6, 2024
OskarStark added a commit that referenced this pull request Feb 7, 2024
This PR was merged into the 6.4 branch.

Discussion
----------

add missing return statement

completes #19505

Commits
-------

ba7d7b7 add missing return statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants