AssetMapper 6.4 docs #19189
Merged
AssetMapper 6.4 docs #19189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, should be ready to go - read and proofread again. The Code Blocks failure isn't legit - it can't find the |
I think asset-mapper is not installed in the test application: https://github.com/symfony-tools/symfony-application/blob/6.4/composer.json |
Apparently I thought of that a long time ago, but forgot: symfony-tools/symfony-application#16 It shouldn't be a blocker. But yes, we should merge that at some point. |
javiereguiluz
approved these changes
Nov 29, 2023
weaverryan
force-pushed
the
asset-mapper-64
branch
from
69f19c9 to
462f5ab
Compare
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
Dec 1, 2023
Looks like this was forgotten to delete after finishing symfony#19189 :-)
javiereguiluz
added a commit
that referenced
this pull request
Dec 5, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [AssetMapper] Removing TODOs Page: https://symfony.com/doc/6.4/frontend/asset_mapper.html#page-specific-css-javascript Looks like `@weaverryan` just forgot to delete this after finishing #19189 :-) Commits ------- 0f91d4d [AssetMapper] Removing TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
A few notable things:
A) Of course, AssetMapper docs were updated for 6.4. Many features were already done - thank you for the community for doing that!
B) I set AssetMapper as the recommended assets solution for 6.4.
C) I Added "Encore" to many of the Encore documentation pages for clarity. I also moved the Encore TOC to its own page. This makes the frontend page short and focused: a landing point to go elsewhere.
Cheers!