Add priority order explanation for tagged services #14513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Nov 3, 2020
|
Awesome. This is really helpful. I remember that I've started making a PR once just enable a priority on tagged listeners... but then realising it is already implemented. |
|
Thank you for your feedbacks :) I have commit your suggestion too. |
javiereguiluz
force-pushed
the
patch-1
branch
from
3108c5c to
958aeaf
Compare
|
Thank you Florian and congrats on your first Symfony Docs contribution! |
apfelbox
reviewed
Nov 4, 2020
| thus providing a way to inject a sorted collection of services: | ||
| The tagged services can be prioritized using the ``priority`` attribute. | ||
| The priority is a positive or negative integer. The higher the number, | ||
| the earlier the tagged service will be located in the collection: |
There was a problem hiding this comment.
Would it make sense to mention the default priority here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this page, the priority order is not explained for tagged services. Since I needed to know this, I guess it is a good addition.
The text is mostly inspired by the paragraph about priority in the event dispatcher documentation : https://symfony.com/doc/current/event_dispatcher.html#creating-an-event-listener
Fell free to edit it or to provide me some advices to do it.
Regards