Skip to content

[Translator] Adding more information about default translation domain 'messages' #14421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

Matts
Copy link

@Matts Matts commented Oct 15, 2020

Fixes #14390

Not 100% sure about the formulation, but just an idea how to make it more clear

@Matts Matts changed the title Adding more information about default translation domain 'messages' [Translator] Adding more information about default translation domain 'messages' Oct 15, 2020
@Matts Matts force-pushed the default-domain-translations branch from fd996d5 to 0931d56 Compare October 16, 2020 05:46
@Matts Matts force-pushed the default-domain-translations branch from 0931d56 to 8e1af9d Compare October 17, 2020 11:52
@Matts
Copy link
Author

Matts commented Oct 17, 2020

Fixed @noniagriconomie

@wouterj
Copy link
Member

wouterj commented Oct 21, 2020

Hi @Matts! Thanks for this PR. I've reduced the changes a bit after merging in ded8825 (the main problem points were "optional" and missing the file name, if I understand the issue correctly). Please let me know if you disagree :)

OskarStark added a commit that referenced this pull request Oct 22, 2020
* 3.4:
  Enhancement: New rules for DOCtor-RST.
  [#14421] Merged the new description into the current sentence
  Adding more information about default translation domain 'messages'
OskarStark added a commit that referenced this pull request Oct 22, 2020
* 4.4:
  Fix: DOCtor-RST
  Enhancement: New rules for DOCtor-RST.
  [#14421] Merged the new description into the current sentence
  Adding more information about default translation domain 'messages'
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Oct 22, 2020
* 5.1:
  add a note about npm commands equivalent to yarn's
  Fix: DOCtor-RST
  Enhancement: New rules for DOCtor-RST.
  [symfony#14421] Merged the new description into the current sentence
  Adding more information about default translation domain 'messages'
@Matts Matts deleted the default-domain-translations branch October 22, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants