add a note about npm commands equivalent to yarn's #13861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +74,21 @@ To build the assets, run: | |||
|
|
|||
| Stop and restart ``encore`` each time you update your ``webpack.config.js`` file. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| If you prefer npm, run these commands instead: | |||
There was a problem hiding this comment.
Maybe add a choice sentence above, like for ex:
« Symfony is not linked to either Yarn neither NPM package manager for your frontend assets, choose the one you are fluent with, and use those command line respectively »
With link to both Yarn and NPM website
That way, it can avoid duplicating the code block and devs can understand they can use both command line for same output :)
noniagriconomie
approved these changes
Oct 10, 2020
|
@nabbisen thanks for this contribution! While merging we changed some things to display these commands alongside the yarn commands, instead of in a separate note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered about which style was good to read.
Finally, I used code-in-note style, which was used in Sub-Domain Routing section.