improve sentence re: content-disposition header
#12653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct English term would be either '...is more involved', or '...involves more effort'
OskarStark
approved these changes
Nov 20, 2019
javiereguiluz
approved these changes
Nov 20, 2019
|
I hope I didn't come across as condescending! I know there are a lot of non-native English speakers in the SF community, so I like to explain why I make each change when it's language-related. |
|
@nealio82 not condescending at all! We do truly appreciate the time you took to explain it because it allows us to learn it for the next time. We always love the fixes and improvements from native English speakers. Thanks a lot! |
|
Thank you Neal. |
xabbuh
added a commit
that referenced
this pull request
Nov 21, 2019
…o82) This PR was merged into the 4.3 branch. Discussion ---------- improve sentence re: `content-disposition` header The correct English term would be either '...is more involved', or '...involves more effort'. 'involving' would be more appropriately used as a supportive clause in a sentence such as: "This feature was a biggie; involving contributions from Fabpot, Stof, and Javiereguiluz" Commits ------- bcbd70d improve sentence re: `content-disposition` header
xabbuh
added a commit
that referenced
this pull request
Nov 21, 2019
|
backported to |
xabbuh
added a commit
that referenced
this pull request
Nov 21, 2019
* 3.4: remove additional blank line fix typo (backport #12653) Add isMasterRequest method Update MySQL column type definition Add some links to objects injected by Symfony in expressions
xabbuh
added a commit
that referenced
this pull request
Nov 21, 2019
* 4.3: [#12637] update after merging up remove additional blank line fix typo (backport #12653) Change the default mapping type to XML Add isMasterRequest method Update MySQL column type definition improve sentence re: `content-disposition` header ContainerAwareEventDispatcher was removed Add some links to objects injected by Symfony in expressions
xabbuh
added a commit
that referenced
this pull request
Nov 21, 2019
* 4.4: [#12637] update after merging up remove additional blank line fix typo (backport #12653) Change the default mapping type to XML Add isMasterRequest method Update MySQL column type definition improve sentence re: `content-disposition` header ContainerAwareEventDispatcher was removed Add some links to objects injected by Symfony in expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct English term would be either '...is more involved', or '...involves more effort'.
'involving' would be more appropriately used as a supportive clause in a sentence such as:
"This feature was a biggie; involving contributions from Fabpot, Stof, and Javiereguiluz"