Skip to content

Add some links to objects injected by Symfony in expressions #12637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

javiereguiluz
Copy link
Member

No description provided.

@javiereguiluz
Copy link
Member Author

Note to mergers (I can merge this myself if you want):

When upmerging to 4.3, you need to make these changes:

  1. Add .. _routing-matching-expressions: reference in the Matching Expressions section in routing.rst
  2. Change the link of the last list item:
.. Before
* :doc:`Variables available in routing expressions </routing/conditions>`.

.. After
* :ref:`Variables available in routing expressions <routing-matching-expressions>`.

@xabbuh
Copy link
Member

xabbuh commented Nov 21, 2019

Thank you Javier.

xabbuh added a commit that referenced this pull request Nov 21, 2019
…ions (javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Add some links to objects injected by Symfony in expressions

Commits
-------

f3cb32e Add some links to objects injected by Symfony in expressions
@xabbuh xabbuh merged commit f3cb32e into symfony:3.4 Nov 21, 2019
xabbuh added a commit that referenced this pull request Nov 21, 2019
xabbuh added a commit that referenced this pull request Nov 21, 2019
* 4.3:
  [#12637] update after merging up
  remove additional blank line
  fix typo (backport #12653)
  Change the default mapping type to XML
  Add isMasterRequest method
  Update MySQL column type definition
  improve sentence re: `content-disposition` header
  ContainerAwareEventDispatcher was removed
  Add some links to objects injected by Symfony in expressions
xabbuh added a commit that referenced this pull request Nov 21, 2019
* 4.4:
  [#12637] update after merging up
  remove additional blank line
  fix typo (backport #12653)
  Change the default mapping type to XML
  Add isMasterRequest method
  Update MySQL column type definition
  improve sentence re: `content-disposition` header
  ContainerAwareEventDispatcher was removed
  Add some links to objects injected by Symfony in expressions
@xabbuh
Copy link
Member

xabbuh commented Nov 21, 2019

Thanks for the detailed instructions, Javier (see 285567d for the changes)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants