Fixed the type of the twig.cache config option #10102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jul 27, 2018
| @@ -121,13 +121,13 @@ application harder to maintain. | |||
| cache | |||
| ~~~~~ | |||
|
|
|||
| **type**: ``string`` **default**: ``'%kernel.cache_dir%/twig'`` | |||
| **type**: ``string`` | ``false`` | ``Twig\Cache\CacheInterface`` **default**: ``'%kernel.cache_dir%/twig'`` | |||
There was a problem hiding this comment.
What does Twig\Cache\CacheInterface stand for here?
There was a problem hiding this comment.
An class implementing that interface. I guessed that anyone so advanced (crazy?) to create their own cache implementation would understand it.
There was a problem hiding this comment.
The point, if I don't miss anything, is that Twig expects an object implementing this interface. Every string will be interpreted as a path. But you cannot pass an object using the semantic configuration.
javiereguiluz
added a commit
that referenced
this pull request
Aug 9, 2018
This PR was merged into the 2.8 branch. Discussion ---------- fix cache option data type see #10102 (comment) Commits ------- 607d23a fix cache option data type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10101.