Skip to content

Commit ed1c1c1

Browse files
committed
Merge branch '4.0' into 4.1
* 4.0: Fixed more occurrences of the wrong handler name bugfixes should be placed for the 2.8 branch
2 parents 4b2818c + c7c57fc commit ed1c1c1

File tree

4 files changed

+18
-24
lines changed

4 files changed

+18
-24
lines changed

README.markdown

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ Contributing
77
------------
88

99
>**Note**
10-
>Unless you're documenting a feature that was introduced *after* Symfony 2.7
11-
>(e.g. in Symfony 2.8), all pull requests must be based off of the **2.7** branch,
10+
>Unless you're documenting a feature that was introduced *after* Symfony 2.8
11+
>(e.g. in Symfony 3.4), all pull requests must be based off of the **2.8** branch,
1212
>**not** the master or older branches.
1313
1414
We love contributors! For more information on how you can contribute to the

contributing/code/patches.rst

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@ software:
1616
* Git;
1717
* PHP version 5.5.9 or above.
1818

19-
.. caution::
20-
21-
Before Symfony 2.7, the minimal PHP version was 5.3.3. Before Symfony 3.0,
22-
minimal version was 5.3.9. Please keep this in mind, if you are working on a
23-
bug fix for earlier versions of Symfony.
24-
2519
Configure Git
2620
~~~~~~~~~~~~~
2721

@@ -112,7 +106,7 @@ Choose the right Branch
112106
Before working on a patch, you must determine on which branch you need to
113107
work:
114108

115-
* ``2.7``, if you are fixing a bug for an existing feature or want to make a
109+
* ``2.8``, if you are fixing a bug for an existing feature or want to make a
116110
change that falls into the :doc:`list of acceptable changes in patch versions
117111
</contributing/code/maintenance>` (you may have to choose a higher branch if
118112
the feature you are fixing was introduced in a later version);
@@ -123,7 +117,7 @@ work:
123117

124118
All bug fixes merged into maintenance branches are also merged into more
125119
recent branches on a regular basis. For instance, if you submit a patch
126-
for the ``2.7`` branch, the patch will also be applied by the core team on
120+
for the ``2.8`` branch, the patch will also be applied by the core team on
127121
the ``master`` branch.
128122

129123
Create a Topic Branch
@@ -136,18 +130,18 @@ topic branch:
136130
137131
$ git checkout -b BRANCH_NAME master
138132
139-
Or, if you want to provide a bugfix for the ``2.7`` branch, first track the remote
140-
``2.7`` branch locally:
133+
Or, if you want to provide a bugfix for the ``2.8`` branch, first track the remote
134+
``2.8`` branch locally:
141135

142136
.. code-block:: terminal
143137
144-
$ git checkout -t origin/2.7
138+
$ git checkout -t origin/2.8
145139
146-
Then create a new branch off the ``2.7`` branch to work on the bugfix:
140+
Then create a new branch off the ``2.8`` branch to work on the bugfix:
147141

148142
.. code-block:: terminal
149143
150-
$ git checkout -b BRANCH_NAME 2.7
144+
$ git checkout -b BRANCH_NAME 2.8
151145
152146
.. tip::
153147

@@ -251,7 +245,7 @@ while to finish your changes):
251245
252246
.. tip::
253247

254-
Replace ``master`` with the branch you selected previously (e.g. ``2.7``)
248+
Replace ``master`` with the branch you selected previously (e.g. ``2.8``)
255249
if you are working on a bugfix
256250

257251
When doing the ``rebase`` command, you might have to fix merge conflicts.
@@ -278,8 +272,8 @@ You can now make a pull request on the ``symfony/symfony`` GitHub repository.
278272

279273
.. tip::
280274

281-
Take care to point your pull request towards ``symfony:2.7`` if you want
282-
the core team to pull a bugfix based on the ``2.7`` branch.
275+
Take care to point your pull request towards ``symfony:2.8`` if you want
276+
the core team to pull a bugfix based on the ``2.8`` branch.
283277

284278
To ease the core team work, always include the modified components in your
285279
pull request message, like in:
@@ -350,7 +344,7 @@ Rework your Patch
350344

351345
Based on the feedback on the pull request, you might need to rework your
352346
patch. Before re-submitting the patch, rebase with ``upstream/master`` or
353-
``upstream/2.7``, don't merge; and force the push to the origin:
347+
``upstream/2.8``, don't merge; and force the push to the origin:
354348

355349
.. code-block:: terminal
356350

logging/monolog_email.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ it is broken down.
1717
# config/packages/prod/monolog.yaml
1818
monolog:
1919
handlers:
20-
mail:
20+
main:
2121
type: fingers_crossed
2222
# 500 errors are logged at the critical level
2323
action_level: critical
@@ -60,7 +60,7 @@ it is broken down.
6060
<monolog:excluded-404>^/</monolog:excluded-404>
6161
-->
6262
<monolog:handler
63-
name="mail"
63+
name="main"
6464
type="fingers_crossed"
6565
action-level="critical"
6666
handler="deduplicated"
@@ -96,7 +96,7 @@ it is broken down.
9696
// config/packages/prod/monolog.php
9797
$container->loadFromExtension('monolog', array(
9898
'handlers' => array(
99-
'mail' => array(
99+
'main' => array(
100100
'type' => 'fingers_crossed',
101101
// 500 errors are logged at the critical level
102102
'action_level' => 'critical',
@@ -125,7 +125,7 @@ it is broken down.
125125
),
126126
));
127127
128-
The ``mail`` handler is a ``fingers_crossed`` handler which means that
128+
The ``main`` handler is a ``fingers_crossed`` handler which means that
129129
it is only triggered when the action level, in this case ``critical`` is reached.
130130
The ``critical`` level is only triggered for 5xx HTTP code errors. If this level
131131
is reached once, the ``fingers_crossed`` handler will log all messages

service_container.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ By putting the ``bind`` key under ``_defaults``, you can specify the value of *a
697697
argument for *any* service defined in this file! You can bind arguments by name
698698
(e.g. ``$adminEmail``) or by type (e.g. ``Psr\Log\LoggerInterface``).
699699

700-
The ``bind`` config can be also be applied to specific services or when loading many
700+
The ``bind`` config can also be applied to specific services or when loading many
701701
services at once (i.e. :ref:`service-psr4-loader`).
702702

703703
Getting Container Parameters as a Service

0 commit comments

Comments
 (0)