Skip to content

Commit 78bc898

Browse files
committed
Merge branch '4.4' into 5.2
* 4.4: Add troubleshooting for parallel merges to maintainer guide Update framework.rst JsonResponse content updated [#14728] Be explicit about the double 's' [Messenger] fix typo [Messenger] Routing & Inheritance [Cache] Add TLS scheme for Redis connection
2 parents bd00733 + 0c57c73 commit 78bc898

File tree

5 files changed

+34
-4
lines changed

5 files changed

+34
-4
lines changed

_build/maintainer_guide.rst

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,26 @@ forgot to merge as ``gh merge NNNNN -s 5.1`` to change the merge branch. Solutio
352352
$ git merge 5.1
353353
$ ...
354354
355+
Merging while the target branch changed
356+
.......................................
357+
358+
Sometimes, someone else merges a PR in ``5.x`` at the same time as you are
359+
doing it. In these cases, ``gh merge ...`` failes to push. Solve this by
360+
resetting your local branch and restarting the merge:
361+
362+
.. code-block:: terminal
363+
364+
$ gh merge ...
365+
# this failed
366+
367+
# fetch the updated 5.x branch from GitHub
368+
$ git fetch upstream
369+
$ git checkout 5.x
370+
$ git reset --hard upstream/5.x
371+
372+
# restart the merge
373+
$ gh merge ...
374+
355375
.. _`symfony/symfony-docs`: https://github.com/symfony/symfony-docs
356376
.. _`Symfony Docs team`: https://github.com/orgs/symfony/teams/team-symfony-docs
357377
.. _`Symfony's respectful review comments`: https://symfony.com/doc/current/contributing/community/review-comments.html

components/cache/adapters/redis_adapter.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,16 @@ helper method allows creating and configuring the Redis client class instance us
6262
);
6363

6464
The DSN can specify either an IP/host (and an optional port) or a socket path, as well as a
65-
password and a database index.
65+
password and a database index. To enable TLS for connections, the scheme ``redis`` must be
66+
replaced by ``rediss`` (the second ``s`` means "secure").
6667

6768
.. note::
6869

6970
A `Data Source Name (DSN)`_ for this adapter must use the following format.
7071

7172
.. code-block:: text
7273
73-
redis://[pass@][ip|host|socket[:port]][/db-index]
74+
redis[s]://[pass@][ip|host|socket[:port]][/db-index]
7475
7576
Below are common examples of valid DSNs showing a combination of available values::
7677

components/http_foundation.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,9 +705,11 @@ class, which can make this even easier::
705705
// if you know the data to send when creating the response
706706
$response = new JsonResponse(['data' => 123]);
707707

708-
// if you don't know the data to send when creating the response
708+
// if you don't know the data to send or if you want to customize the encoding options
709709
$response = new JsonResponse();
710710
// ...
711+
// configure any custom encoding options (if needed, it must be called before "setData()")
712+
//$response->setEncodingOptions(JsonResponse::DEFAULT_ENCODING_OPTIONS | \JSON_PRESERVE_ZERO_FRACTION);
711713
$response->setData(['data' => 123]);
712714

713715
// if the data to send is already encoded in JSON

messenger.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,13 @@ to multiple transports:
313313
],
314314
]);
315315
316+
.. note::
317+
318+
If you configure routing for both a child and parent class, both rules
319+
are used. E.g. if you have an ``SmsNotification`` object that extends
320+
from ``Notification``, both the routing for ``Notification`` and
321+
``SmsNotification`` will be used.
322+
316323
Doctrine Entities in Messages
317324
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
318325

reference/configuration/framework.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1416,7 +1416,7 @@ The value can be one of:
14161416
``true``
14171417
Throw an exception when the requirements are not met;
14181418
``false``
1419-
Disable exceptions when the requirements are not met and return ``null``
1419+
Disable exceptions when the requirements are not met and return ``''``
14201420
instead;
14211421
``null``
14221422
Disable checking the requirements (thus, match the route even when the

0 commit comments

Comments
 (0)