[Fwb][TwigBundle] Remove Twig Preview controller routing in favor of fwb #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
fabpot
approved these changes
Nov 14, 2019
nicolas-grekas
approved these changes
Nov 14, 2019
ghost
pushed a commit
that referenced
this pull request
Nov 14, 2019
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 4, 2020
…alteschlueter) This PR was merged into the 4.4 branch. Discussion ---------- Update information in flex about added files for twig The information about the recipe files of the twig-bundle are outdated for symfony 4.4 and 5. * The route configuration file for the dev environment in the recipe of the twig-bundle was removed last year * symfony/recipes#675 * A package configuration file was added for the test environment * symfony/recipes#666 * Maybe this change must be also documented in 3.4 or what do you think? Commits ------- 91ee76e Update information in flex about added files for twig
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIU, the controller for this route is deprecated in favor of the
HttpKernelone registered through the fwb recipe. So new projects starting with Twig 4.4 should not start with this deprecated route, and use the fwb one instead.