Proofreading webpack.config.js for clarity #440
Conversation
ghost
deployed
to
weaverryan
changed the title
|
|
||
| .cleanupOutputBeforeBuild() | ||
| .enableSourceMaps(!Encore.isProduction()) | ||
|
|
||
| // the following line enables hashed filenames (e.g. app.abc123.css) | ||
| // enables hashed filenames (e.g. app.abc123.css) |
There was a problem hiding this comment.
Maybe a hint telling that it's a good practice to use it conjointedly with framework.assets.json_manifest_path?
| .enableVersioning(Encore.isProduction()) | ||
|
|
||
| // uncomment to define the assets of the project | ||
| //.addEntry('js/app', './assets/js/app.js') | ||
| //.addStyleEntry('css/app', './assets/css/app.scss') |
There was a problem hiding this comment.
As you added a default JS entry, why not add one for CSS too?
There was a problem hiding this comment.
addStyleEntry is kind of an anti-pattern. So, I doc'ed it, but people shouldn't really need to use it, if they want to do things correctly.
|
Thanks for the reviews! I've got a WIP on this, so that I can create a corresponding PR to the docs so that everything is consistent (and we can merge at nearly the same time). I'll ping back when that's ready :) |
* Adding initial js and css files * removing sass by default to avoid needing extra packages * enabling notifications
weaverryan
changed the title
|
This is ready for review! The big differences are that I created an I've updated the docs with this change in mind: symfony/symfony-docs#10128 |
…weaverryan) This PR was squashed before being merged into the 3.4 branch (closes #10128). Discussion ---------- [WCM] Updating the Encore documentation + New recipe See symfony/recipes#440 Basically, after a year+ of using Encore, I updated the recipe to follow best practices & clarity. This updates the docs to follow that recipe. Hopefully it makes Encore even more accessible :). Cheers! Commits ------- 9b53860 [WCM] Updating the Encore documentation + New recipe
Re-reading the default webpack.config.js file for clarity. I'm also updating the documentation at the moment, and will base those changes off of this.