excluded_http_codes might not work properly

[Sengorius]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	4.1

I'm currently using monolog to get informed about errors from a multi-user-site. For my current setup I used https://symfony.com/blog/new-in-symfony-4-1-ignore-specific-http-codes-from-logs as resource.

As you can see below, I tried to exclude 403 and 404 errors (especially) from mailing handler. As for all 404 it might work, but I'm still receiving mails on any 403 error.

# config/packages/prod/monolog.yaml
monolog:
    handlers:
        main:
            type: fingers_crossed
            action_level: error
            handler: grouped
            excluded_http_codes: [403, 404]

        grouped:
            type: group
            members: [nested, mailer]

        nested:
            type: rotating_file
            path: "%kernel.logs_dir%/%kernel.environment%.log"
            level: debug
            max_files: 30

        mailer:
            type: deduplication
            handler: swift_mail

        swift_mail:
            type: swift_mailer
            from_email: '%env(MAILER_DEFAULT_MAIL)%'
            to_email: '%env(MAILER_SERVICE_MAIL)%'
            subject: 'Exception in M-OBS: %%message%%'
            level: debug
            formatter: monolog.formatter.html
            content_type: text/html
            excluded_http_codes: [403, 404]

        console:
            type: console
            process_psr_3_messages: false
            channels: ["!event", "!doctrine"]

Can you please fix this or is it my error?

[JohJohan]

@Sengorius i can also confirm this, i think excluded_http_codes is only available for fingers_crossed type handler. I have tried to implement it for the slack handler and it also ignores it.

[javiereguiluz]

When we documented this feature, I asked the same. See: symfony/symfony-docs#8235 (comment) Apparently this is for some technical reason ... but personally it doesn't make any sense to me. This should work for all handlers.

[Seldaek]

Other handlers have no way to filter records.. so you need to wrap them in a fingers crossed handler, which can contain a group handler with all other handlers in it if you want to filter 403/404s from all handlers for example. Fixing this would require generating fingers crossed handler instances on the fly around every handler configured with excluded_http_codes, which sounds nasty to me.

Marking as a bug though because the bundle should error in case this config value is used on a handler that doesn't support it.

[boris-brtan]

is that change backward compatible ? @Seldaek

[drzraf]

Reaching that bug for the same use-case I'm wondering:

Why type=filter doesn't provide these http-code options, and more importantly why is there two similar handlers:

• filter
• fingers_crossed
  each having with a different set of option names (fingers_crossed simply seems more powerful).
  I think this needs documenting.