[make:*] Fluent setters bundle configuration option

[prugala]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#297
License	MIT

Based on #297

At the moment we cannot decide that we want to generate fluent or not fluent setters.

I read the discussion in an issue and I added global configuration option:

maker:
  fluent_setters: false // default: true

[maks-rafalko]

Are you going to finish it @prugala?

[prugala]

@maks-rafalko oh I forgot about it. Yes I will finish it. I will try to add tests and update docs this week.

[prugala]

OK I added tests and updated doc section.
@weaverryan could you look or call someone who can do it. Thanks :)

[AlboCode]

Any news about this PR?
What is it missing?

[prugala]

@AlboCode I see conflicts, I will fix it tomorrow and will ask about merge :)

[AlboCode]

@AlboCode I see conflicts, I will fix it tomorrow and will ask about merge :)

Thanks 👍

[prugala]

Sorry for ping but PR is old and I forgot to end it before. Now its ready with tests.

@nicolas-grekas @weaverryan and docs change so @javiereguiluz :)

[BatsaxIV]

Hi,

Besides what I reviewed in your code, I think that your forgot to update one maker, the MakeRegistrationForm.

https://github.com/symfony/maker-bundle/blob/master/src/Maker/MakeRegistrationForm.php#L309 : Here it can update a user class with a isVerified property and its setter that is fluent by default.

I think something like that should do the trick:

$userManipulator = new ClassSourceManipulator(
    file_get_contents($classDetails->getPath()),
    true,
    true,
    $generator->getFluentSetters()
);

Jérémy.

[BatsaxIV]

I'm not familiar with the test for this bundle, but I can't figured out where this file is used (The others fixtures files are used in \Symfony\Bundle\MakerBundle\Tests\Maker*).

[prugala]

Yes I forgot about test, added.

[acornforth]

This is just what I have been looking for. A must if we want to use maker in applications that have already defined non-fluent interfaces to implement on our entities (Sylius).
How long would this typically take to be merged now that tests are passing?

[prugala]

@BatsaxIV thank you again for review. I've added missing parameter there and in few other places. Now All "Manipulators"
use custom parameter.

[hockdudu]

Is there something holding this PR back?

[prugala]

Is there something holding this PR back?

I resolve conflicts today later and I think all should be ready to merge :)

[jaroslavtyc]

Any chance to move this forward? Guys from my team refuse to use maker for entities because of forced fluent interface, which brings whole bunch of new troubles.

Yea, it is more about people than code, but this fluent_setters: false would help with people.-)

Thanks!

[bytes-commerce]

Since its been some time with this PR, I'd like to take the chance and un-necro it before it gets stale over a year again.

I'd love to see this configuration being pushed to prod so that we can go back to non-fluent setters. Thanks everyone involved pushing this forward.

[bytes-commerce]

Sorry to ping again. @prugala just in case you're still contributing to the project, I believe that many people would be happy to see your changes. If not, please let us know so that maybe someone else can take over from here on. 🙏

[prugala]

@NopeNopeNope sorry for lack of activity. I'll update PR to current code base today or tomorrow :)