Skip to content

[make:entity] doctine/persistence v4 support, drop xml entity config support #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

kbond
Copy link
Member

@kbond kbond commented Mar 26, 2025

  • drops support for xml configured entities
  • doctrine/persistence dropped StaticReflectionService - added backport

@kbond kbond changed the title wip Fix tests Mar 26, 2025
@kbond kbond force-pushed the fix/reflection-service branch from 63918e5 to 55c01bc Compare March 26, 2025 12:57
@weaverryan
Copy link
Member

We should drop ``regenerate: that's an antiquated flag to go from XML -> entity class. We should be 100% all-in on attribute mapping. I don't consider this a BC break as the make:` commands can't realistically be used in automated scripts.

That being said a 2.0 major is overdue

@kbond kbond force-pushed the fix/reflection-service branch 2 times, most recently from 3553975 to 67b8638 Compare April 25, 2025 13:43
@kbond kbond changed the title Fix tests doctine/persistence v4 support, drop xml entity config support Apr 25, 2025
@kbond kbond marked this pull request as ready for review April 25, 2025 14:12
@kbond kbond changed the title doctine/persistence v4 support, drop xml entity config support [make:entity] doctine/persistence v4 support, drop xml entity config support Apr 25, 2025
@kbond kbond force-pushed the fix/reflection-service branch from 2108dd8 to 7b7f069 Compare April 25, 2025 14:18
@kbond kbond merged commit 2140aff into symfony:main Apr 25, 2025
@kbond kbond deleted the fix/reflection-service branch April 25, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants