Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:validator] generate final classes #1589

Merged
merged 3 commits into from
Sep 13, 2024
Merged

[make:validator] generate final classes #1589

merged 3 commits into from
Sep 13, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Aug 31, 2024 •
edited
Loading

generates final classes for the generated validator and constraint based on MakerBundle's config preferences

  • adds generated file comparison to test suite
  • adds a new internal generator method to create classes from ClassData objects - this will replace the existing generateClass() method in the future.
  • adds test fixture to compare generated code to our template

@jrushlow jrushlow added the Feature New Feature label Aug 31, 2024
@jrushlow jrushlow added this to the v1.62.0 milestone Aug 31, 2024
@jrushlow jrushlow merged commit fb404cc into symfony:main Sep 13, 2024
9 checks passed
@jrushlow jrushlow deleted the feature/final/validator branch September 13, 2024 12:57
@jrushlow jrushlow mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature New Feature
Projects
None yet
Milestone
v1.62.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jrushlow