Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make:twig-extension] Change folder for Twig Extension #1211

Merged
merged 2 commits into from
Sep 26, 2022
Merged

[make:twig-extension] Change folder for Twig Extension #1211

merged 2 commits into from
Sep 26, 2022

Conversation

seb-jean
Copy link
Contributor

I think it would be interesting to put the Twig Extensions in a src/Twig/Extension folder rather than src/Twig. The idea is to do like the Twig Components.

@seb-jean seb-jean changed the title Update MakeTwigExtension.php [make:twig-extension] Change folder for Twig Extension Sep 26, 2022
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
@jrushlow jrushlow added the Feature New Feature label Sep 26, 2022
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seb-jean!

@weaverryan
Copy link
Member

Devil's advocate: what else do you have in the src/Twig/ directory? Same thing with forms - I like putting them in src/Form instead of src/Form/Type because, most of the time, they will be the only thing in src/Form :)

@seb-jean
Copy link
Contributor Author

Devil's advocate: what else do you have in the src/Twig/ directory? Same thing with forms - I like putting them in src/Form instead of src/Form/Type because, most of the time, they will be the only thing in src/Form :)

Now, I have a folder src/Twig/Components and files src/Twig/...Extension.php

@weaverryan
Copy link
Member

haha, that's a good point 😆 . Ok then 👍

@jrushlow jrushlow added the Status: Reviewed Has been reviewed by a maintainer label Sep 26, 2022
@jrushlow jrushlow merged commit 14de6f8 into symfony:main Sep 26, 2022
@jrushlow jrushlow mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants