Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:entity] _em will be private in ORM 3.0, use getEntityManager() #1114

Merged
merged 1 commit into from
May 9, 2022
Merged

[make:entity] _em will be private in ORM 3.0, use getEntityManager() #1114

merged 1 commit into from
May 9, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented May 9, 2022 •
edited
Loading

In ORM 3.0 the Doctrine\ORM\EntityRepository::_em property will be private, we should use EntityRepository::getEntityManager() instead.

@jrushlow jrushlow changed the title [make:entity] _em will be private in ORM 3.0 [make:entity] _em will be private in ORM 3.0, use getEntityManager() May 9, 2022
@jrushlow jrushlow added Feature New Feature Status: Needs Review Needs to be reviewed labels May 9, 2022
weaverryan
weaverryan reviewed May 9, 2022
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment

src/Resources/skeleton/doctrine/Repository.tpl.php Outdated Show resolved Hide resolved
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 8011758 into symfony:main May 9, 2022
@jrushlow jrushlow deleted the fix/private-em branch May 9, 2022 17:11
@jrushlow jrushlow mentioned this pull request May 9, 2022
Merged
@seb-jean seb-jean mentioned this pull request May 18, 2022
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrushlow @weaverryan