Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:entity] Exclude inherited embedded class properties #1046

Merged
merged 1 commit into from
Feb 23, 2022
Merged

[make:entity] Exclude inherited embedded class properties #1046

merged 1 commit into from
Feb 23, 2022

Conversation

Vincz
Copy link
Contributor

@Vincz Vincz commented Jan 8, 2022

Fix #1045

jrushlow
jrushlow requested changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Could you rebase this PR please. We've fixed a number of broken tests since you've opened the PR. Thanks in advanced.

@jrushlow jrushlow changed the title Exclude inherited embedded class properties [make:entity] Exclude inherited embedded class properties Feb 15, 2022
@jrushlow jrushlow added the Status: Needs Review Needs to be reviewed label Feb 15, 2022
jrushlow
jrushlow approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @Vincz

@jrushlow jrushlow added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Feb 23, 2022
@jrushlow jrushlow merged commit fd869b6 into symfony:main Feb 23, 2022
@jrushlow jrushlow mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[make:entity --regenerate] Inherited embedded classes should be ignored
2 participants
@Vincz @jrushlow