Fix PHP 8.1 deprecations #1016
Merged
Fix PHP 8.1 deprecations #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Nov 20, 2021
| @@ -714,7 +714,7 @@ private function updateContents(string $newContents, array $newData, int $newPos | |||
| private function convertToYaml($data) | |||
| { | |||
| $indent = $this->depth > 0 && isset($this->indentationForDepths[$this->depth]) | |||
| ? $this->indentationForDepths[$this->depth] / $this->depth | |||
There was a problem hiding this comment.
💡 This division might evaluate to a float value. The problem is that $indent is implicitly cast to an integer later and PHP 8.1 will complain if that implicit cast would result in a loss of precision. Since the loss in precision is actually desired here, I'm performing an integer division instead which will always yield an integer.
derrabus
commented
Nov 20, 2021
| @@ -1132,7 +1132,7 @@ private function removeMetadataKeys(array $data) | |||
| unset($data[$key]); | |||
| } | |||
|
|
|||
| if (0 === strpos($val, self::COMMENT_PLACEHOLDER_VALUE)) { | |||
| if (null !== $val && 0 === strpos($val, self::COMMENT_PLACEHOLDER_VALUE)) { | |||
There was a problem hiding this comment.
💡 Passing null to strpos() will trigger a deprecation on PHP 8.1.
|
Thank you @derrabus! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two pieces of code that trigger a deprecation error on PHP 8.1. You can see them in the CI output of #1012.