Fixing tests + one missing return

Author: weaverryan

src/Maker/MakeEntity.php

@@ -551,6 +551,8 @@ function ($name) use ($targetClass) {
         $askInverseSide = function (EntityRelation $relation) use ($io) {
             if ($this->isClassInVendor($relation->getInverseClass())) {
                 $relation->setMapInverseRelation(false);
+
+                return;
             }
 
             // recommend an inverse side, except for OneToOne, where it's inefficient

tests/Doctrine/fixtures/expected_xml/src/Repository/UserRepository.php

@@ -6,6 +6,12 @@
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Symfony\Bridge\Doctrine\RegistryInterface;
 
+/**
+ * @method User|null find($id, $lockMode = null, $lockVersion = null)
+ * @method User|null findOneBy(array $criteria, array $orderBy = null)
+ * @method User[]    findAll()
+ * @method User[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
+ */
 class UserRepository extends ServiceEntityRepository
 {
     public function __construct(RegistryInterface $registry)

tests/Maker/FunctionalTest.php

@@ -258,8 +258,6 @@ public function getCommandTests()
                 'UserAvatarPhoto',
                 // relation type
                 'OneToMany',
-                // inverse side?
-                'y',
                 // field name on opposite side - use default 'user'
                 '',
                 // nullable
@@ -337,8 +335,6 @@ public function getCommandTests()
                 'ManyToOne',
                 // the target entity
                 'Some\Vendor\Group',
-                // nullable
-                'n',
                 /*
                  * normally, we ask for the field on the *other* side, but we
                  * do not here, since the other side won't be mapped.