Adding the "length" question for the string type

Author: weaverryan

appveyor.yml

@@ -50,6 +50,6 @@ install:
     - ./vendor/bin/simple-phpunit install
 
 test_script:
-    - ./vendor/bin/simple-phpunit --group=functional_group1 --stop-on-error
-    - ./vendor/bin/simple-phpunit --group=functional_group2 --stop-on-error
+    - ./vendor/bin/simple-phpunit --group=functional_group1
+    - ./vendor/bin/simple-phpunit --group=functional_group2
     - ./vendor/bin/simple-phpunit --exclude-group=functional_group1,functional_group2

src/Maker/MakeEntity.php

@@ -351,7 +351,7 @@ private function askForNextField(ConsoleStyle $io, array $fields, string $entity
         $data = ['fieldName' => $fieldName, 'type' => $type];
         if ('string' == $type) {
             // default to 255, avoid the question
-            $data['length'] = 255;
+            $data['length'] = $io->ask('Field length', 255, [Validator::class, 'validateLength']);;
         } elseif ('decimal' === $type) {
             // 10 is the default value given in \Doctrine\DBAL\Schema\Column::$_precision
             $data['precision'] = $io->ask('Precision (total number of digits stored: 100.00 would be 5)', 10, [Validator::class, 'validatePrecision']);

tests/Maker/FunctionalTest.php

@@ -307,6 +307,7 @@ public function getCommandEntityTests()
                 // add not additional fields
                 'name',
                 'string',
+                '', // length (default 255)
                 // nullable
                 'y',
                 'createdAt',
@@ -332,6 +333,7 @@ public function getCommandEntityTests()
                 // add additional fields
                 'lastName',
                 'string',
+                '', // length (default 255)
                 // nullable
                 'y',
                 // finish adding fields
@@ -681,6 +683,7 @@ public function getCommandEntityTests()
                 // field name
                 'firstName',
                 'string',
+                '', // length (default 255)
                 // nullable
                 '',
                 // finish adding fields