[make:entity] doctine/persistence v4 support, drop xml entity config support

Author: kbond

src/Doctrine/DoctrineHelper.php

@@ -24,7 +24,6 @@
 use Doctrine\Persistence\Mapping\Driver\MappingDriver;
 use Doctrine\Persistence\Mapping\Driver\MappingDriverChain;
 use Doctrine\Persistence\Mapping\MappingException as PersistenceMappingException;
-use Doctrine\Persistence\Mapping\StaticReflectionService;
 use Symfony\Bundle\MakerBundle\Util\ClassNameDetails;
 use Symfony\Component\Uid\Ulid;
 use Symfony\Component\Uid\Uuid;

src/Doctrine/StaticReflectionService.php

@@ -0,0 +1,62 @@
+<?php
+
+/*
+ * This file is part of the Symfony MakerBundle package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\MakerBundle\Doctrine;
+
+use Doctrine\Persistence\Mapping\ReflectionService;
+
+/**
+ * @internal replacing removed Doctrine\Persistence\Mapping\StaticReflectionService
+ */
+final class StaticReflectionService implements ReflectionService
+{
+    public function getParentClasses($class): array
+    {
+        return [];
+    }
+
+    public function getClassShortName($class): string
+    {
+        $nsSeparatorLastPosition = strrpos($class, '\\');
+
+        if (false !== $nsSeparatorLastPosition) {
+            $class = substr($class, $nsSeparatorLastPosition + 1);
+        }
+
+        return $class;
+    }
+
+    public function getClassNamespace($class): string
+    {
+        $namespace = '';
+
+        if (str_contains($class, '\\')) {
+            $namespace = strrev(substr(strrev($class), (int) strpos(strrev($class), '\\') + 1));
+        }
+
+        return $namespace;
+    }
+
+    public function getClass($class): \ReflectionClass
+    {
+        return new \ReflectionClass($class);
+    }
+
+    public function getAccessibleProperty($class, $property): ?\ReflectionProperty
+    {
+        return null;
+    }
+
+    public function hasPublicMethod($class, $method): bool
+    {
+        return true;
+    }
+}

tests/Doctrine/EntityRegeneratorTest.php

@@ -63,19 +63,6 @@ public function getRegenerateEntitiesTests(): \Generator
         ];
     }
 
-    public function testXmlRegeneration(): void
-    {
-        $kernel = new TestXmlEntityRegeneratorKernel('dev', true);
-        $this->doTestRegeneration(
-            __DIR__.'/fixtures/xml_source_project',
-            $kernel,
-            'Symfony\Bundle\MakerBundle\Tests\tmp\current_project_xml\src\Entity',
-            'expected_xml',
-            false,
-            'current_project_xml'
-        );
-    }
-
     private function doTestRegeneration(string $sourceDir, Kernel $kernel, string $namespace, string $expectedDirName, bool $overwrite, string $targetDirName): void
     {
         $fs = new Filesystem();