Adding an enhanced make:entity command

This is now interactive, supports:

* Adding scalar fields
* Adding relations
* Can update an existing entity
* synchronizes owning side of entity relations
* respects phpcs in generated code
* --regenerate flag to add getters/setters for existing properties

This also improves the testing system yet again to be much more
powerful.

Author: weaverryan

.php_cs.dist

@@ -7,9 +7,19 @@ return PhpCsFixer\Config::create()
     ->setRules(array(
         '@Symfony' => true,
         '@Symfony:risky' => true,
-        'array_syntax' => array('syntax' => 'short'),
+        'array_syntax' => ['syntax' => 'short'],
         'protected_to_private' => false,
         'semicolon_after_instruction' => false,
+        'header_comment' => [
+            'header' => <<<EOF
+This file is part of the Symfony package.
+
+(c) Fabien Potencier <fabien@symfony.com>
+
+For the full copyright and license information, please view the LICENSE
+file that was distributed with this source code.
+EOF
+        ]
     ))
     ->setRiskyAllowed(true)
     ->setFinder(

.travis.yml

@@ -7,7 +7,6 @@ git:
     depth: 1
 
 php:
-  - 7.0
   - 7.1
   - 7.2
 

composer.json

@@ -12,15 +12,20 @@
         }
     ],
     "require": {
-        "php": "^7.0.8",
+        "php": "^7.1.3",
+        "doctrine/inflector": "^1.2",
+        "nikic/php-parser": "4.0.0alpha3",
         "symfony/config": "^3.4|^4.0",
         "symfony/console": "^3.4|^4.0",
         "symfony/dependency-injection": "^3.4|^4.0",
         "symfony/filesystem": "^3.4|^4.0",
+        "symfony/finder": "^3.4|^4.0",
         "symfony/framework-bundle": "^3.4|^4.0",
         "symfony/http-kernel": "^3.4|^4.0"
     },
     "require-dev": {
+        "doctrine/doctrine-bundle": "^1.8",
+        "doctrine/orm": "^2.6",
         "friendsofphp/php-cs-fixer": "^2.8",
         "symfony/phpunit-bridge": "^3.4|^4.0",
         "symfony/process": "^3.4|^4.0"

phpunit.xml.dist

@@ -9,6 +9,7 @@
 >
     <php>
         <ini name="error_reporting" value="-1" />
+        <env name="TEST_DATABASE_DSN" value="mysql://root:@127.0.0.1:3306/test_maker" />
     </php>
 
     <testsuites>

src/DependencyBuilder.php

@@ -53,4 +53,21 @@ public function getMissingDependencies(): array
 
         return array_merge($missingPackages, $missingOptionalPackages);
     }
+
+    /**
+     * @internal
+     */
+    public function getAllRequiredDependencies(): array
+    {
+        $dependencies = [];
+        foreach ($this->dependencies as $class => $package) {
+            if (!$package['required']) {
+                continue;
+            }
+
+            $dependencies[] = $package['name'];
+        }
+
+        return $dependencies;
+    }
 }

src/DependencyInjection/CompilerPass/MakeCommandRegistrationPass.php

@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace Symfony\Bundle\MakerBundle\DependencyInjection\CompilerPass;
 
 use Symfony\Bundle\MakerBundle\Command\MakerCommand;

src/Doctrine/BaseCollectionRelation.php

@@ -0,0 +1,34 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\MakerBundle\Doctrine;
+
+use Symfony\Bundle\MakerBundle\Str;
+
+/**
+ * @internal
+ */
+abstract class BaseCollectionRelation extends BaseRelation
+{
+    abstract public function getOrphanRemoval(): bool;
+
+    abstract public function getTargetSetterMethodName(): string;
+
+    public function getAdderMethodName(): string
+    {
+        return 'add'.Str::asCamelCase(Str::pluralCamelCaseToSingular($this->getPropertyName()));
+    }
+
+    public function getRemoverMethodName(): string
+    {
+        return 'remove'.Str::asCamelCase(Str::pluralCamelCaseToSingular($this->getPropertyName()));
+    }
+}

src/Doctrine/BaseRelation.php

@@ -0,0 +1,73 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\MakerBundle\Doctrine;
+
+/**
+ * @internal
+ */
+abstract class BaseRelation
+{
+    private $propertyName;
+    private $targetClassName;
+    private $targetPropertyName;
+    private $mapInverseRelation = true;
+
+    abstract public function isOwning(): bool;
+
+    public function getPropertyName()
+    {
+        return $this->propertyName;
+    }
+
+    public function setPropertyName($propertyName)
+    {
+        $this->propertyName = $propertyName;
+
+        return $this;
+    }
+
+    public function getTargetClassName()
+    {
+        return $this->targetClassName;
+    }
+
+    public function setTargetClassName($targetClassName)
+    {
+        $this->targetClassName = $targetClassName;
+
+        return $this;
+    }
+
+    public function getTargetPropertyName()
+    {
+        return $this->targetPropertyName;
+    }
+
+    public function setTargetPropertyName(?string $targetPropertyName)
+    {
+        $this->targetPropertyName = $targetPropertyName;
+
+        return $this;
+    }
+
+    public function getMapInverseRelation(): bool
+    {
+        return $this->mapInverseRelation;
+    }
+
+    public function setMapInverseRelation(bool $mapInverseRelation)
+    {
+        $this->mapInverseRelation = $mapInverseRelation;
+
+        return $this;
+    }
+}

src/Doctrine/BaseSingleRelation.php

@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\MakerBundle\Doctrine;
+
+/**
+ * @internal
+ */
+abstract class BaseSingleRelation extends BaseRelation
+{
+    private $isNullable;
+
+    public function isNullable(): bool
+    {
+        return $this->isNullable;
+    }
+
+    public function setIsNullable($isNullable)
+    {
+        $this->isNullable = $isNullable;
+
+        return $this;
+    }
+}

src/Doctrine/DoctrineMetadataFactory.php

@@ -0,0 +1,86 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\MakerBundle\Doctrine;
+
+use Doctrine\Common\Persistence\ManagerRegistry;
+use Doctrine\ORM\Mapping\ClassMetadata;
+use Doctrine\ORM\Tools\DisconnectedClassMetadataFactory;
+
+/**
+ * Simpler version of DoctrineBundle's DisconnectedMetadataFactory, to
+ * avoid PSR-4 issues.
+ *
+ * @author Fabien Potencier <fabien@symfony.com>
+ * @author Ryan Weaver <ryan@knpuniversity.com>
+ */
+final class DoctrineMetadataFactory
+{
+    private $registry;
+
+    /**
+     * Constructor.
+     *
+     * @param ManagerRegistry $registry A ManagerRegistry instance
+     */
+    public function __construct(ManagerRegistry $registry)
+    {
+        $this->registry = $registry;
+    }
+
+    /**
+     * @param string $namespace
+     *
+     * @return array|ClassMetadata[]
+     */
+    public function getMetadataForNamespace($namespace)
+    {
+        $metadata = [];
+        foreach ($this->getAllMetadata() as $m) {
+            if (0 === strpos($m->name, $namespace)) {
+                $metadata[] = $m;
+            }
+        }
+
+        return $metadata;
+    }
+
+    public function getMetadataForClass(string $entity): ?ClassMetadata
+    {
+        foreach ($this->registry->getManagers() as $em) {
+            $cmf = new DisconnectedClassMetadataFactory();
+            $cmf->setEntityManager($em);
+
+            if (!$cmf->isTransient($entity)) {
+                return $cmf->getMetadataFor($entity);
+            }
+        }
+
+        return null;
+    }
+
+    /**
+     * @return array
+     */
+    private function getAllMetadata()
+    {
+        $metadata = [];
+        foreach ($this->registry->getManagers() as $em) {
+            $cmf = new DisconnectedClassMetadataFactory();
+            $cmf->setEntityManager($em);
+            foreach ($cmf->getAllMetadata() as $m) {
+                $metadata[] = $m;
+            }
+        }
+
+        return $metadata;
+    }
+}