Skip to content

Commit 9966ef2

Browse files
committed
Merge branch '5.4' into 6.3
* 5.4: [WebProfilerBundle] Fix JS error when evaluating scripts don't fail when optional dependencies are not present fix syntax error on PHP 7.2
2 parents 7440f74 + 078e109 commit 9966ef2

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2812,8 +2812,8 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
28122812
if (ContainerBuilder::willBeAvailable('symfony/mercure-notifier', NotifierBridge\Mercure\MercureTransportFactory::class, $parentPackages) && ContainerBuilder::willBeAvailable('symfony/mercure-bundle', MercureBundle::class, $parentPackages) && \in_array(MercureBundle::class, $container->getParameter('kernel.bundles'), true)) {
28132813
$container->getDefinition($classToServices[NotifierBridge\Mercure\MercureTransportFactory::class])
28142814
->replaceArgument('$registry', new Reference(HubRegistry::class))
2815-
->replaceArgument('$client', new Reference('http_client'))
2816-
->replaceArgument('$dispatcher', new Reference('event_dispatcher'));
2815+
->replaceArgument('$client', new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2816+
->replaceArgument('$dispatcher', new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
28172817
} elseif (ContainerBuilder::willBeAvailable('symfony/mercure-notifier', NotifierBridge\Mercure\MercureTransportFactory::class, $parentPackages)) {
28182818
$container->removeDefinition($classToServices[NotifierBridge\Mercure\MercureTransportFactory::class]);
28192819
}
@@ -2822,16 +2822,16 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
28222822
$container->getDefinition($classToServices[NotifierBridge\FakeChat\FakeChatTransportFactory::class])
28232823
->replaceArgument('$mailer', new Reference('mailer'))
28242824
->replaceArgument('$logger', new Reference('logger'))
2825-
->replaceArgument('$client', new Reference('http_client'))
2826-
->replaceArgument('$dispatcher', new Reference('event_dispatcher'));
2825+
->replaceArgument('$client', new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2826+
->replaceArgument('$dispatcher', new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
28272827
}
28282828

28292829
if (ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', NotifierBridge\FakeSms\FakeSmsTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'])) {
28302830
$container->getDefinition($classToServices[NotifierBridge\FakeSms\FakeSmsTransportFactory::class])
28312831
->replaceArgument('$mailer', new Reference('mailer'))
28322832
->replaceArgument('$logger', new Reference('logger'))
2833-
->replaceArgument('$client', new Reference('http_client'))
2834-
->replaceArgument('$dispatcher', new Reference('event_dispatcher'));
2833+
->replaceArgument('$client', new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2834+
->replaceArgument('$dispatcher', new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
28352835
}
28362836

28372837
if (isset($config['admin_recipients'])) {

0 commit comments

Comments
 (0)