Add-lines patcher can not be converted from .yaml to .php

[alexander-schranz]

Stumbled over that add-lines implemented in #975 is now used not only for phpunit.xml.dist files or .js, ... files but also for config recipes files.

Sadly used for config/packages/.. or config/routes/.. I personally would avoid using that and have another mechanism there.

Maybe merged .yaml or even own notifier_...yaml would be better there.

This kind of configurations can currently this way not be converted to PHP based recipes. And I don't see a way for do it, without somebody need todo this manually for every recipe.

This recipe patches will so fail on PHP based config recipes repo currently: https://github.com/schranz-php-recipes/symfony-recipes-php/pull/44/files#

[nicolas-grekas]

Of course. That's why we stick to yaml files. php config files are not something we support here.

[stof]

@alexander-schranz if you make an unofficial recipes server using the PHP config files, it means your builder also need to convert those add-lines patchers to patch PHP files instead (find which other recipe defines the original file, apply the patch on the original file, convert the patched file, and then make a diff between the converted patched and the converted original file to find out how the patch should look like for the converted recipe). But that's an issue for your own builder, not for this repo.

[alexander-schranz]

@stof the target of the project was never to have unofficial recipe server for PHP configs ;) it's more a prototype to official support PHP configs at some time in the official flex recipes here, without the need to maintain yaml and php configs inside them. So that a job can use that kind of config converter to provide via official flex support for yaml and php configs.

With the issue I wanted to make aware that moving recipes in direction of using add-lines for config files it will make a step backwards for have support for PHP based configs in its full potential. If the core team of symfony says they never try to plan to have support for php config in flex recipes I'm more to way of closing the project. As in the past I thought there where a direction with @Nyholm config builders, remove xml and yaml config from core and some presentation I think from @chalasr if I remember correctly that there is more a direction from go away from Yaml instead of stay with it.