bug #1048 Fix needless call to flex API on composer i (nicolas-grekas)

This PR was merged into the 2.x branch.

Discussion
----------

Fix needless call to flex API on composer i

Fix #1040

Commits
-------

cfe894c Fix needless call to flex API on composer i

Author: nicolas-grekas

src/PackageFilter.php

@@ -65,7 +65,7 @@ public function removeLegacyPackages(array $data, RootPackageInterface $rootPack
             $rootConstraints[$name] = $link->getConstraint();
         }
 
-        $knownVersions = $this->getVersions();
+        $knownVersions = null;
         $filteredPackages = [];
         $symfonyPackages = [];
         $oneSymfony = false;
@@ -77,8 +77,8 @@ public function removeLegacyPackages(array $data, RootPackageInterface $rootPack
             }
 
             if ('symfony/symfony' !== $name && (
-                !isset($knownVersions['splits'][$name])
-                || array_intersect($versions, $lockedVersions[$name] ?? [])
+                array_intersect($versions, $lockedVersions[$name] ?? [])
+                || (($knownVersions ??= $this->getVersions()) && !isset($knownVersions['splits'][$name]))
                 || (isset($rootConstraints[$name]) && !Intervals::haveIntersections($this->symfonyConstraints, $rootConstraints[$name]))
                 || ('symfony/psr-http-message-bridge' === $name && 6.4 > $versions[0])
             )) {

tests/PackageFilterTest.php

@@ -32,7 +32,7 @@ class PackageFilterTest extends TestCase
     public function testRemoveLegacyPackages(array $expected, array $packages, string $symfonyRequire, array $versions, array $lockedPackages = [])
     {
         $downloader = $this->getMockBuilder('Symfony\Flex\Downloader')->disableOriginalConstructor()->getMock();
-        $downloader->expects($this->once())
+        $downloader->expects($this->any())
             ->method('getVersions')
             ->willReturn($versions);
         $filter = new PackageFilter(new NullIO(), $symfonyRequire, $downloader);