Fixed deprecation warnings about passing null as parameter

derrabus · derrabus · commit 4675a128d2e8 · 2021-05-16T11:52:47.000+02:00
diff --git a/Comparator/NumberComparator.php b/Comparator/NumberComparator.php
@@ -41,8 +41,8 @@ class NumberComparator extends Comparator
      */
     public function __construct(?string $test)
     {
-        if (!preg_match('#^\s*(==|!=|[<>]=?)?\s*([0-9\.]+)\s*([kmg]i?)?\s*$#i', $test, $matches)) {
-            throw new \InvalidArgumentException(sprintf('Don\'t understand "%s" as a number test.', $test));
+        if (null === $test || !preg_match('#^\s*(==|!=|[<>]=?)?\s*([0-9\.]+)\s*([kmg]i?)?\s*$#i', $test, $matches)) {
+            throw new \InvalidArgumentException(sprintf('Don\'t understand "%s" as a number test.', $test ?? 'null'));
         }
 
         $target = $matches[2];

Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,8 @@ class NumberComparator extends Comparator`
`41`	`41`	`*/`
`42`	`42`	`public function __construct(?string $test)`
`43`	`43`	`{`
`44`		`- if (!preg_match('#^\s(==\|!=\|[<>]=?)?\s([0-9\.]+)\s([kmg]i?)?\s$#i', $test, $matches)) {`
`45`		`- throw new \InvalidArgumentException(sprintf('Don\'t understand "%s" as a number test.', $test));`
	`44`	`+ if (null === $test \|\| !preg_match('#^\s(==\|!=\|[<>]=?)?\s([0-9\.]+)\s([kmg]i?)?\s$#i', $test, $matches)) {`
	`45`	`+ throw new \InvalidArgumentException(sprintf('Don\'t understand "%s" as a number test.', $test ?? 'null'));`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`$target = $matches[2];`