Optimized some strlen() calls when possible

Author: javiereguiluz

Helper/QuestionHelper.php

@@ -382,7 +382,7 @@ private function mostRecentlyEnteredValue(string $entered): string
         }
 
         $choices = explode(',', $entered);
-        if (\strlen($lastChoice = trim($choices[\count($choices) - 1])) > 0) {
+        if ('' !== $lastChoice = trim($choices[\count($choices) - 1])) {
             return $lastChoice;
         }
 

Input/StringInput.php

@@ -50,9 +50,9 @@ private function tokenize(string $input): array
         while ($cursor < $length) {
             if (preg_match('/\s+/A', $input, $match, 0, $cursor)) {
             } elseif (preg_match('/([^="\'\s]+?)(=?)('.self::REGEX_QUOTED_STRING.'+)/A', $input, $match, 0, $cursor)) {
-                $tokens[] = $match[1].$match[2].stripcslashes(str_replace(['"\'', '\'"', '\'\'', '""'], '', substr($match[3], 1, \strlen($match[3]) - 2)));
+                $tokens[] = $match[1].$match[2].stripcslashes(str_replace(['"\'', '\'"', '\'\'', '""'], '', substr($match[3], 1, -1)));
             } elseif (preg_match('/'.self::REGEX_QUOTED_STRING.'/A', $input, $match, 0, $cursor)) {
-                $tokens[] = stripcslashes(substr($match[0], 1, \strlen($match[0]) - 2));
+                $tokens[] = stripcslashes(substr($match[0], 1, -1));
             } elseif (preg_match('/'.self::REGEX_STRING.'/A', $input, $match, 0, $cursor)) {
                 $tokens[] = stripcslashes($match[1]);
             } else {