[AIBundle] Fix stream result profiling #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 20, 2025
Contributor
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
AssertSame where possible please
valtzu
force-pushed
the
fix-stream-profiler
branch
from
fb0cf29 to
53a05cb
Compare
OskarStark
approved these changes
Jul 20, 2025
chr-hertel
reviewed
Jul 20, 2025
Comment on lines
+71
to
+81
| private function createTraceableStreamResult(\Generator $originalStream): StreamResult | ||
| { | ||
| return $result = new StreamResult((function () use (&$result, $originalStream) { | ||
| $this->resultCache[$result] = ''; | ||
| foreach ($originalStream as $chunk) { | ||
| yield $chunk; | ||
| if (\is_string($chunk)) { | ||
| $this->resultCache[$result] .= $chunk; | ||
| } | ||
| } | ||
| })()); |
Member
|
Thank you @valtzu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address 2 streaming-related issues:
symfony/aifrom withinStreamedResponsecallback (in http controller), no data was collected due to not implementingLateDataCollectorInterfaceStreamResultto the profiler storage always failed, because\Generators are not serializableBoth are used in the Turbo Stream Bot demo, and now the profiler works. Though the toolbar still does not auto-update, but that is currently expected behavior.