feature #834 Qdrant sync (natewiebe13)

This PR was squashed before being merged into the main branch.

Discussion
----------

 Qdrant sync

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| Docs?         | no
| License       | MIT

Currently, Qdrant PUT operations are async. This forces the user to add checking after the request happens to determine if it was successful or not.

This adds an option to make operations sync so you can handle any errors immediately instead of polling after until the operation completes.

Commits
-------

89ed6b8  Qdrant sync

Author: OskarStark

src/ai-bundle/config/options.php

@@ -607,6 +607,7 @@
                                 ->stringNode('collection_name')->cannotBeEmpty()->end()
                                 ->integerNode('dimensions')->end()
                                 ->stringNode('distance')->end()
+                                ->booleanNode('async')->defaultFalse()->end()
                             ->end()
                         ->end()
                     ->end()

src/ai-bundle/src/AiBundle.php

@@ -1112,6 +1112,10 @@ private function processStoreConfig(string $type, array $stores, ContainerBuilde
                     $arguments[5] = $store['distance'];
                 }
 
+                if (\array_key_exists('async', $store)) {
+                    $arguments[6] = $store['async'];
+                }
+
                 $definition = new Definition(QdrantStore::class);
                 $definition
                     ->addTag('ai.store')

src/ai-bundle/tests/DependencyInjection/AiBundleTest.php

@@ -2967,6 +2967,7 @@ private function getFullConfig(): array
                             'collection_name' => 'foo',
                             'dimensions' => 768,
                             'distance' => 'Cosine',
+                            'async' => false,
                         ],
                     ],
                     'redis' => [

src/store/src/Bridge/Qdrant/Store.php

@@ -33,6 +33,7 @@ public function __construct(
         private readonly string $collectionName,
         private readonly int $embeddingsDimension = 1536,
         private readonly string $embeddingsDistance = 'Cosine',
+        private readonly bool $async = false,
     ) {
     }
 
@@ -58,9 +59,14 @@ public function setup(array $options = []): void
 
     public function add(VectorDocument ...$documents): void
     {
-        $this->request('PUT', \sprintf('collections/%s/points', $this->collectionName), [
-            'points' => array_map($this->convertToIndexableArray(...), $documents),
-        ]);
+        $this->request(
+            'PUT',
+            \sprintf('collections/%s/points', $this->collectionName),
+            [
+                'points' => array_map($this->convertToIndexableArray(...), $documents),
+            ],
+            ['wait' => $this->async ? 'false' : 'true'],
+        );
     }
 
     /**
@@ -102,17 +108,19 @@ public function drop(): void
 
     /**
      * @param array<string, mixed> $payload
+     * @param array<string, mixed> $queryParameters
      *
      * @return array<string, mixed>
      */
-    private function request(string $method, string $endpoint, array $payload = []): array
+    private function request(string $method, string $endpoint, array $payload = [], array $queryParameters = []): array
     {
         $url = \sprintf('%s/%s', $this->endpointUrl, $endpoint);
 
         $response = $this->httpClient->request($method, $url, [
             'headers' => [
                 'api-key' => $this->apiKey,
             ],
+            'query' => $queryParameters,
             'json' => $payload,
         ]);
 

src/store/tests/Bridge/Qdrant/StoreTest.php

@@ -145,15 +145,52 @@ public function testStoreCannotAddOnInvalidResponse()
         $store = new Store($httpClient, 'http://127.0.0.1:6333', 'test', 'test');
 
         $this->expectException(ClientException::class);
-        $this->expectExceptionMessage('HTTP 400 returned for "http://127.0.0.1:6333/collections/test/points".');
+        $this->expectExceptionMessage('HTTP 400 returned for "http://127.0.0.1:6333/collections/test/points?wait=true".');
         $this->expectExceptionCode(400);
         $store->add(new VectorDocument(Uuid::v4(), new Vector([0.1, 0.2, 0.3])));
     }
 
     public function testStoreCanAdd()
     {
-        $httpClient = new MockHttpClient([
-            new JsonMockResponse([
+        $document = new VectorDocument(Uuid::v4(), new Vector([0.1, 0.2, 0.3]));
+
+        $httpClient = new MockHttpClient(static function (string $method, string $url, array $options) use ($document): JsonMockResponse {
+            self::assertArrayHasKey('wait', $options['query']);
+            self::assertEquals('true', $options['query']['wait']);
+
+            return new JsonMockResponse([
+                'time' => 0.002,
+                'status' => 'ok',
+                'result' => [
+                    'points' => [
+                        [
+                            'id' => (string) $document->id,
+                            'payload' => (array) $document->metadata,
+                            'vector' => $document->vector->getData(),
+                        ],
+                    ],
+                ],
+            ], [
+                'http_code' => 200,
+            ]);
+        }, 'http://127.0.0.1:6333');
+
+        $store = new Store($httpClient, 'http://127.0.0.1:6333', 'test', 'test');
+
+        $store->add($document);
+
+        $this->assertSame(1, $httpClient->getRequestsCount());
+    }
+
+    public function testStoreCanAddAsynchronously()
+    {
+        $document = new VectorDocument(Uuid::v4(), new Vector([0.1, 0.2, 0.3]));
+
+        $httpClient = new MockHttpClient(static function (string $method, string $url, array $options): JsonMockResponse {
+            self::assertArrayHasKey('wait', $options['query']);
+            self::assertEquals('false', $options['query']['wait']);
+
+            return new JsonMockResponse([
                 'time' => 0.002,
                 'status' => 'ok',
                 'result' => [
@@ -162,12 +199,12 @@ public function testStoreCanAdd()
                 ],
             ], [
                 'http_code' => 200,
-            ]),
-        ], 'http://127.0.0.1:6333');
+            ]);
+        }, 'http://127.0.0.1:6333');
 
-        $store = new Store($httpClient, 'http://127.0.0.1:6333', 'test', 'test');
+        $store = new Store($httpClient, 'http://127.0.0.1:6333', 'test', 'test', async: true);
 
-        $store->add(new VectorDocument(Uuid::v4(), new Vector([0.1, 0.2, 0.3])));
+        $store->add($document);
 
         $this->assertSame(1, $httpClient->getRequestsCount());
     }